-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go.mod versions for pulumi, update master, and exclude failing conformance tests #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5356431
to
326b10f
Compare
tie
reviewed
Feb 22, 2025
13 tasks
tgummerer
reviewed
Feb 24, 2025
326b10f
to
31ec89a
Compare
b1989d1
to
a2ced92
Compare
tgummerer
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, minus the still failing test.
go.mod
Outdated
go 1.21 | ||
go 1.22 | ||
|
||
toolchain go1.23.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is making the test fail. I don't think we need the toolchain
line here?
…onformance tests This will hopefully be the last time this needs to be done manually before Renovate bot handles bumping. Also removes typeddict reference from schema list as it was removed as a part of pulumi/pulumi#17350
a2ced92
to
094678b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully be the last time this needs to be done manually
before Renovate bot handles bumping.
Fixes #715