Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Cleanup #3

Open
ConnorNelson opened this issue May 1, 2023 · 1 comment
Open

Improve Cleanup #3

ConnorNelson opened this issue May 1, 2023 · 1 comment

Comments

@ConnorNelson
Copy link
Member 

The parent-death signal setting is also
cleared upon changes to any of the following thread
credentials: effective user ID, effective group ID,
filesystem user ID, or filesystem group ID.

-- https://man7.org/linux/man-pages/man2/prctl.2.html

We need to make sure pid 1 gets killed.
@ConnorNelson
Copy link
Member Author

A good temporary option is to set_parent_death_signal() after all the setuid() code in start(). However, this is almost certainly prone to race conditions if we aren't careful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ConnorNelson