Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests to use schema functions #831

Closed
adriangb opened this issue Jul 27, 2023 · 2 comments
Closed

Convert tests to use schema functions #831

adriangb opened this issue Jul 27, 2023 · 2 comments
Assignees
@davidhewitt
Labels
refactor

Comments

@adriangb
Copy link
Member

adriangb commented Jul 27, 2023 •
edited by pydantic-hooky bot
Loading

A lot of our tests use plain dicts. This makes them brittle and hard to refactor. We should convert from {'type': 'str'} -> core_schema.str_schema().

Selected Assignee: @davidhewitt
@sydney-runkle
Copy link
Member

This is going to be incredibly laborious 😭

@mikeedjones mikeedjones mentioned this issue Feb 10, 2025
Merged
4 tasks
@davidhewitt
Copy link
Contributor

Done in #1631, thanks @mikeedjones!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhewitt davidhewitt

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adriangb @davidhewitt @sydney-runkle