-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbose error handling for non-valid duckarrays #9314
Merged
Illviljan
merged 8 commits into
pydata:main
from
Illviljan:namedarray_verbose_error_handling_non_valid_duckarray
Aug 8, 2024
Merged
Verbose error handling for non-valid duckarrays #9314
Illviljan
merged 8 commits into
pydata:main
from
Illviljan:namedarray_verbose_error_handling_non_valid_duckarray
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mypy CI is uninstalling numpy 2.0.1 and installing numpy 1.26 instead for some reason, anyone know why?
|
pandas-stubs forces numpy <2.0.0 now: pandas-dev/pandas-stubs#943 |
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
array API standard
Support for the Python array API standard
plan to merge
Final call for comments
topic-arrays
related to flexible array support
topic-error reporting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is rather annoying trying to figure out why some arrays aren't valid duckarrays. This PR logs the missing attributes instead of just saying it isn't valid.
Example:
Further reading: python/cpython#104873