Skip to content

List all registered torchx.schedulers #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clumsy opened this issue Feb 17, 2025 · 3 comments
Open

List all registered torchx.schedulers #1009

clumsy opened this issue Feb 17, 2025 · 3 comments

Comments

@clumsy
Copy link
Contributor

clumsy commented Feb 17, 2025

Description

Currently we can only have the default ones or the custom ones (from one of the packages): https://github.com/pytorch/torchx/blob/main/torchx/schedulers/__init__.py#L59

Motivation/Background

This will allow adding new schedulers locally without re-registering the default schedulers. The list gets stale when new default schedulers are added to TorchX

Detailed Proposal

Make it work the same way as named_resources (simply list all) or components (allow referencing via _0, _1, etc.)

Alternatives

Keep re-registering the default schedulers

Additional context/links

@clumsy
Copy link
Contributor Author

clumsy commented Feb 17, 2025

For your consideration, @d4l3k @kiukchung @tonykao8080

@clumsy
Copy link
Contributor Author

clumsy commented Apr 23, 2025

Any concerns before I submit the contribution, @d4l3k , @kiukchung , @tonykao8080?

@clumsy
Copy link
Contributor Author

clumsy commented Apr 23, 2025

The fix to simply merge/overwrite existing schedulers is trivial (publishing PR). The only question is whether we want to support the same _0/_1 behavior as for components here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant