This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
Add base url #31
Open
Add base url #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, created a pull request too soon. Apparently some further code changes are needed. I only tried to front page which works fine, but once I hit the 'GO' button, it fails. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a small patch to add the option of a base URL. I'm running behind a reverse proxy and found this lacking.
This was a simple two line code, and I have verified manually that it works with or without the base-url option in the config file. I've never touched clojure before, and I fear I may be calling the load_config twice. That is fine by me since it is only done at startup, but should probably be optimised.
This patch addresses #28