Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move link outside of footnote #1556

Merged
merged 2 commits into from
Jan 24, 2025
Merged

docs: move link outside of footnote #1556

merged 2 commits into from
Jan 24, 2025

Conversation

mcanouil
Copy link
Contributor

Currently the link to the full documentation on inline code is "hidden" inside the footnote.
It would be better for it to be clearly visible.
The footnote is mostly there to say the knitr syntax is supported.

@cderv
Copy link
Collaborator

cderv commented Jan 24, 2025

/deploy-preview

Copy link
Contributor

🚀 Deployed on https://deploy-preview-1556.quarto.org

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

It would indeed be good to not link only from the footnote.

Though I find the "Read more in inline code" not well place.

I think I would add something at the end of the paragraph like in next "Caching" part

You can find out more about caching in Quarto documents in the Cache documentation.

Also I would keep the link in the footnote too.

What do you think ?

@mcanouil
Copy link
Contributor Author

I rephrased/added a sentence with the link (put back the link in the footnote).
I still think the mention to the complete documentation should come early and then the examples.

@cderv
Copy link
Collaborator

cderv commented Jan 24, 2025

/deploy-preview

@cderv cderv merged commit 846a57c into quarto-dev:main Jan 24, 2025
3 checks passed
Copy link
Contributor

Successfully created backport PR for prerelease:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants