Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update python versions in CI #251

Merged
merged 5 commits into from
Apr 24, 2024
Merged

chore: update python versions in CI #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d918e8
chore: update python versions in CI
cjrh Apr 24, 2024
150972e
Prerelease syntax for 3.13
cjrh Apr 24, 2024
fd198d5
Supply allow-prereleases to setup-python
cjrh Apr 24, 2024
2c9eea5
Set allow-prereleases on all matrix steps
cjrh Apr 24, 2024
6a0f899
Fix array
cjrh Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,21 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.9]
python-version: ["3.12"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change, aren't we removing 3.8?

Copy link
Collaborator Author

@cjrh cjrh Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 3.12 is the current stable version, so that's the one we should test across platforms
  • 3.8 is still supported by upstream

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

allow-prereleases: [false]
include:
- os: ubuntu-latest
python-version: "3.12"
python-version: "3.13"
allow-prereleases: true
- os: ubuntu-latest
python-version: "3.11"
allow-prereleases: false
- os: ubuntu-latest
python-version: "3.10"
allow-prereleases: false
- os: ubuntu-latest
python-version: 3.8
allow-prereleases: false
runs-on: "${{ matrix.os }}"
steps:
- name: Harden Runner
Expand All @@ -72,6 +77,7 @@ jobs:
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # 5.1.0
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: ${{ matrix.allow-prereleases }}

- uses: dtolnay/rust-toolchain@bb45937a053e097f8591208d8e74c90db1873d07
with:
Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import nox


@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12"])
@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove 3.8 from here

def test(session):
session.install("-rrequirements-dev.txt")
session.install("-e", ".", "--no-build-isolation")
Expand Down
Loading