-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): let condition
be undefined
#9
Conversation
Hello @adamhamlin, let me know if this solution makes sense to you. It's based on your feedback in sodiray/radash#269. I'm open to a |
5fe1e6d
to
591d640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @adamhamlin, let me know if this solution makes sense to you. It's based on your feedback in sodiray/radash#269.
I'm open to a
selectFirst
contribution, too!
Yep, looks good! And sure, I can open a PR for selectFirst
3e61d98
to
47f126a
Compare
d115036
to
a75176a
Compare
61915dc
to
ab9b8be
Compare
@adamhamlin I hope you didn't start on that yet. I just reorganized the repository to have one module per function, so rebasing onto main could be annoying. 😅 |
@aleclarson nope, hadn't started yet, no worries! |
Description
If the
condition
parameter is undefined, themapper
result is checked with!= null
instead, sonull
andundefined
results are omitted from the new array.Checklist
/docs
directory) has been updatedResolves
Resolves sodiray/radash#269