Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Songticker for shows that are not Klangbecken isn't readable #20

Open
hairmare opened this issue Jan 29, 2025 · 1 comment
Open

Songticker for shows that are not Klangbecken isn't readable #20

hairmare opened this issue Jan 29, 2025 · 1 comment

Comments

@hairmare
Copy link
Member

hairmare commented Jan 29, 2025

I just noticed that Radio Goethe is showing up as Goethe Radio:

Image

The XML from nowplaying looks like this:

<ticker>
  <identifier>ticker-c9d66c46-d8ad-4a94-8926-50c4861c0134</identifier>
  <creator>now-playing daemon v2</creator>
  <date>2025-01-29T23:00:03+01:00</date>
  <show id="05c47247-ea64-4e3e-9436-d13fcaff6a26">
    <name>Radio Goethe</name>
    <link xlink:type="simple" xlink:href="https://rabe.ch/radio-goethe" xlink:show="replace">https://rabe.ch/radio-goethe</link>
    <startTime>2025-01-29T23:00:00+01:00</startTime>
    <endTime>2025-01-30T00:00:00+01:00</endTime>
  </show>
  <track id="2fab0a9c-e8b0-4879-8b22-01aca50e7a1c">
    <show ref="05c47247-ea64-4e3e-9436-d13fcaff6a26">Radio Goethe</show>
    <artist>Radio Bern</artist>
    <title>Livestream</title>
    <startTime>2025-01-29T23:00:00+01:00</startTime>
    <endTime>2025-01-30T00:00:00+01:00</endTime>
  </track>
</ticker>

Under the hood it seems to render the show name twice as follows:

<div dir="auto" class="css-1rynq56">
  <span class="css-1qaijid" style="white-space: nowrap; font-family: &quot;__FontBold_da8fd3&quot;, &quot;__FontBold_Fallback_da8fd3&quot;; font-size: 18px; font-weight: 100; font-feature-settings: &quot;tnum&quot;; color: rgb(227, 249, 248);">Radio Goethe </span>
  <span class="css-1qaijid" style="white-space: nowrap; font-family: &quot;__FontBold_da8fd3&quot;, &quot;__FontBold_Fallback_da8fd3&quot;; font-size: 18px; font-weight: 100; font-feature-settings: &quot;tnum&quot;; color: rgb(227, 249, 248);">Radio Goethe </span>
</div>

Most likely this is related to #19 and we should just never render the /ticker/track/show element.

I've also heard people say that the ticker scrolls through the text if it doesn't fit in the ticker div, i've never seen that in action in any of my browsers, but it would have made me less confused.

@hairmare
Copy link
Member Author

hairmare commented Feb 5, 2025

Seems to be improving:

Firefox Chrome
Image Image

The "Jetzt auf Sendung" seems redundant, esp. given how little space we have available and the whole show name still doesn't fit the allotted space.

@hairmare hairmare changed the title Songticker for Radio Goethe Songticker for shows that are not Klangbecken Feb 9, 2025
@hairmare hairmare changed the title Songticker for shows that are not Klangbecken Songticker for shows that are not Klangbecken isn't readable Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant