-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update report #7696
update report #7696
Conversation
256dbd4
to
fc21714
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7696 +/- ##
=======================================
Coverage 23.00% 23.00%
=======================================
Files 34 34
Lines 3500 3500
=======================================
Hits 805 805
Misses 2647 2647
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appears to need a go mod tidy
due to new imports from the s3upload binary.
Also, does this really belong here? This appears to add a dependency on aws-sdk-go that I do not believe we currently have. Could this go in https://github.com/rancher/ecm-distro-tools?
fc21714
to
a7c217b
Compare
|
Signed-off-by: Francisco <francisco.moral@suse.com>
a7c217b
to
83587e9
Compare
# Generate report and upload to s3 bucket | ||
cd createreport && /usr/local/go/bin/go run -v report-template-bindata.go generate_report.go -f rke2_${OS}.log | ||
# Upload to s3 bucket | ||
cd report && /usr/local/go/bin/go run -v s3upload.go -f rke2_${OS}.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: EOF
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments