Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update report #7696

Merged
merged 1 commit into from
Feb 10, 2025
Merged

update report #7696

merged 1 commit into from
Feb 10, 2025

Conversation

fmoral2
Copy link
Contributor

@fmoral2 fmoral2 commented Feb 6, 2025

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@fmoral2 fmoral2 requested a review from a team as a code owner February 6, 2025 13:46
@fmoral2 fmoral2 self-assigned this Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.00%. Comparing base (c1e854d) to head (83587e9).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7696   +/-   ##
=======================================
  Coverage   23.00%   23.00%           
=======================================
  Files          34       34           
  Lines        3500     3500           
=======================================
  Hits          805      805           
  Misses       2647     2647           
  Partials       48       48           
Flag Coverage Δ
inttests 8.74% <ø> (ø)
unittests 16.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears to need a go mod tidy due to new imports from the s3upload binary.

Also, does this really belong here? This appears to add a dependency on aws-sdk-go that I do not believe we currently have. Could this go in https://github.com/rancher/ecm-distro-tools?

@fmoral2
Copy link
Contributor Author

fmoral2 commented Feb 10, 2025

appears to need a go mod tidy due to new imports from the s3upload binary.

Also, does this really belong here? This appears to add a dependency on aws-sdk-go that I do not believe we currently have. Could this go in https://github.com/rancher/ecm-distro-tools?

  • The dependency was already there, actually i removed one as direct - 'cobra'
  • since we are uploading a report from e2e tests, i cant see why go to tools. But if you prefer i can delete the directory and just have a file on the e2e/uploads3.go

Signed-off-by: Francisco <francisco.moral@suse.com>
# Generate report and upload to s3 bucket
cd createreport && /usr/local/go/bin/go run -v report-template-bindata.go generate_report.go -f rke2_${OS}.log
# Upload to s3 bucket
cd report && /usr/local/go/bin/go run -v s3upload.go -f rke2_${OS}.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EOF

@brandond brandond self-requested a review February 10, 2025 18:13
@fmoral2 fmoral2 merged commit 14356e6 into rancher:master Feb 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants