From 05e810a535c55f9e8712b248d47760af1ce4512d Mon Sep 17 00:00:00 2001 From: James Lamb Date: Fri, 31 Jan 2025 10:13:32 -0600 Subject: [PATCH] disallow fallback to Make in wheel builds (#1804) Contributes to https://github.com/rapidsai/build-planning/issues/146 Proposes: * setting `[tool.scikit-build].ninja.make-fallback = false`, so `scikit-build-core` will not silently fallback to using GNU Make if `ninja` is not available Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: https://github.com/rapidsai/rmm/pull/1804 --- python/librmm/pyproject.toml | 4 ++-- python/rmm/pyproject.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/python/librmm/pyproject.toml b/python/librmm/pyproject.toml index bae2ef36b..6fee31c9a 100644 --- a/python/librmm/pyproject.toml +++ b/python/librmm/pyproject.toml @@ -1,4 +1,4 @@ -# Copyright (c) 2024, NVIDIA CORPORATION. +# Copyright (c) 2024-2025, NVIDIA CORPORATION. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -57,7 +57,7 @@ build-dir = "build/{wheel_tag}" cmake.build-type = "Release" cmake.version = "CMakeLists.txt" minimum-version = "build-system.requires" -ninja.make-fallback = true +ninja.make-fallback = false sdist.reproducible = true wheel.packages = ["librmm"] wheel.install-dir = "librmm" diff --git a/python/rmm/pyproject.toml b/python/rmm/pyproject.toml index 6036e9c56..d457b0913 100644 --- a/python/rmm/pyproject.toml +++ b/python/rmm/pyproject.toml @@ -59,7 +59,7 @@ build-dir = "build/{wheel_tag}" cmake.build-type = "Release" cmake.version = "CMakeLists.txt" minimum-version = "build-system.requires" -ninja.make-fallback = true +ninja.make-fallback = false sdist.exclude = ["*tests*"] sdist.reproducible = true wheel.packages = ["rmm"]