Merge pull request #136 from temptemp3/main

Author: jeapostrophe

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reach-sh/humble-sdk",
-  "version": "2.1.2",
+  "version": "2.1.3",
   "description": "A Javascript library for interacting with the HumbleSwap DEx",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

src/participants/PoolAnnouncer.test.ts

@@ -0,0 +1,57 @@
+import { createReachAPI, initHumbleSDK } from "../index";
+import {
+  safeMintedLiquidityTokens,
+  unsafeMintedLiquidityTokens,
+} from "./PoolAnnouncer";
+
+initHumbleSDK();
+
+const mintedLiquidityTokens = "100000000000000000000000000000";
+
+const Info = jest.fn().mockImplementation(() => {
+  const bn = createReachAPI().bigNumberify;
+  return {
+    liquidityToken: bn(1),
+    lptBals: {
+      A: bn(0),
+      B: bn(mintedLiquidityTokens),
+    },
+    poolBals: {
+      A: bn(0),
+      B: bn(0),
+    },
+    protoBals: {
+      A: bn(0),
+      B: bn(0),
+    },
+    protoInfo: {
+      locked: false,
+      lpFee: 2,
+      protoAddr: "",
+      protoFee: 3,
+      totFee: 5,
+    },
+    tokA: bn(1),
+    tokB: bn(2),
+  };
+});
+
+describe.only("Fetch Liquidity Pool", () => {
+  it("Converts minted liquidity to big int as string", async () => {
+    expect(safeMintedLiquidityTokens(createReachAPI())(Info().lptBals)).toBe(
+      mintedLiquidityTokens
+    );
+  });
+});
+
+describe.only("Fetch Liquidity Pool", () => {
+  it("Unable to convert minted liquidity tokens to number", async () => {
+    expect(() => {
+      try {
+        unsafeMintedLiquidityTokens(createReachAPI())(Info().lptBals);
+      } catch (e) {
+        throw new Error(e);
+      }
+    }).toThrow("NUMERIC_FAULT")
+  });
+});

src/participants/PoolAnnouncer.ts

@@ -6,7 +6,8 @@ import {
   formatCurrency,
   formatAddress,
   ReachToken,
-  peraTokenMetadata
+  peraTokenMetadata,
+  ReachStdLib
 } from "../reach-helpers";
 import {
   FetchPoolData,
@@ -34,6 +35,22 @@ export type FetchPoolOpts = PoolFetchOpts & {
 /** ALIAS | Fetch data about a pool */
 export const fetchPool = fetchLiquidityPool;
 
+/**
+ * Get minted liquidity tokens (unsafe)
+ * @param stdlib Reach stdlib
+ * @param lptBals Liquidity token balances
+ * @returns Minted liquidity tokens
+ */
+export const unsafeMintedLiquidityTokens = (stdlib: ReachStdLib) => (lptBals: {A: any; B: any}) => stdlib.bigNumberToNumber(lptBals.B)
+
+/**
+ * Get minted liquidity tokens
+ * @param stdlib Reach stdlib
+ * @param lptBals Liquidity token balances
+ * @returns Minted liquidity tokens
+ */
+export const safeMintedLiquidityTokens = (stdlib: ReachStdLib) => (lptBals: {A: any; B: any}) => stdlib.bigNumberToBigInt(lptBals.B).toString()
+
 /**
  * Fetch data about a pool
  * @param acc Reach Account instance
@@ -46,7 +63,8 @@ export async function fetchLiquidityPool(
   opts: FetchPoolOpts
 ): Promise<TransactionResult<FetchPoolData>> {
   const reach = createReachAPI();
-  const big = reach.bigNumberify;
+  const bn = reach.bigNumberify;
+  const getMintedLiquidityTokens = safeMintedLiquidityTokens(reach);
   const {
     poolAddress = "",
     n2nn = false,
@@ -105,15 +123,15 @@ export async function fetchLiquidityPool(
   onProgress(`Calculating fees ...`);
   const FEE_INFO = getFeeInfo();
   const totalFees = (protocolBal: number) =>
-    big(FEE_INFO.totFee).div(big(FEE_INFO.protoFee)).mul(protocolBal);
+    bn(FEE_INFO.totFee).div(bn(FEE_INFO.protoFee)).mul(protocolBal);
 
   // subtract fees from token balances
   const { A: aBal, B: bBal } = poolBals;
   const { A: pABal, B: pBBal } = protoBals;
   const pool: PoolDetails = {
     poolAddress: ctcInfo,
     poolTokenId: parseAddress(liquidityToken),
-    mintedLiquidityTokens: reach.bigNumberToNumber(lptBals.B),
+    mintedLiquidityTokens: getMintedLiquidityTokens(lptBals),
     n2nn,
     tokenABalance: formatCurrency(aBal, tokA?.decimals),
     tokenAFees: formatCurrency(totalFees(pABal), tokA?.decimals),