Syncing latest changes from upstream master for rook #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds liveness probe call ceph cmd with mons and keyring, but ceph actually looks for the ceph keyring at default folder first and then use the cmd line keyring path, So to avoid that use ceph_args env variable to expose the keyring folder path, Workaround for https://tracker.ceph.com/issues/70167 closes: rook#15373 Signed-off-by: parth-gr <partharora1010@gmail.com>
mds: fix mds liveness probe
…th 6 updates Bumps the github-dependencies group with 6 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) | `0.31.0` | `0.32.0` | | [github.com/google/go-cmp](https://github.com/google/go-cmp) | `0.6.0` | `0.7.0` | | [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault) | `1.15.0` | `1.16.0` | | [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) | `0.80.0` | `0.80.1` | | [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) | `0.80.0` | `0.80.1` | | [github.com/spf13/cobra](https://github.com/spf13/cobra) | `1.8.1` | `1.9.1` | Updates `github.com/ceph/go-ceph` from 0.31.0 to 0.32.0 - [Release notes](https://github.com/ceph/go-ceph/releases) - [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md) - [Commits](ceph/go-ceph@v0.31.0...v0.32.0) Updates `github.com/google/go-cmp` from 0.6.0 to 0.7.0 - [Release notes](https://github.com/google/go-cmp/releases) - [Commits](google/go-cmp@v0.6.0...v0.7.0) Updates `github.com/hashicorp/vault/api` from 1.15.0 to 1.16.0 - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG-v1.10-v1.15.md) - [Commits](hashicorp/vault@v1.15.0...v1.16.0) Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.80.0 to 0.80.1 - [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases) - [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md) - [Commits](prometheus-operator/prometheus-operator@v0.80.0...v0.80.1) Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.80.0 to 0.80.1 - [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases) - [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md) - [Commits](prometheus-operator/prometheus-operator@v0.80.0...v0.80.1) Updates `github.com/spf13/cobra` from 1.8.1 to 1.9.1 - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.1...v1.9.1) --- updated-dependencies: - dependency-name: github.com/ceph/go-ceph dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/google/go-cmp dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/hashicorp/vault/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies ... Note: Requires some cascaded updates to ./api go modules as well. Signed-off-by: dependabot[bot] <support@github.com>
…dependencies-8e097e19d0 build(deps): bump the github-dependencies group across 1 directory with 6 updates
ubuntu 20.04 is going to unsupported by April 1 and there are planned brownouts planned from March 4th. so let's upgrade to version 22.04. Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai
approved these changes
Feb 27, 2025
ci: update ubuntu version to 22.04 or latest
Some ceph health errors should not block the reconcile of the cluster. Mgr modules do not have cause to block the reconcile, as the cluster can usually work even if a module is failing. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
There is a race condition in ceph v19 at startup of a stretch cluster where if the .mgr pool is created by the mgr pod after stretch mode is entered, the devicehealth mgr module will crash and cause a ceph HEALTH_ERR. The error then causes rook reconcile of all CRs to be skipped because Rook is assuming admin intervention is needed to continue. The fix is to wait until the .mgr pool is created by the mgr pod before entering stretch mode. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
This checks the documentation sources for syntactic correctness The functionality is essentially extracted from the docs-check workflow to provide developers with a tool to locally run the corresponding check before pushing Signed-off-by: Michael Adam <obnox@samba.org>
This adds a command 'make golangci-lint' This is done so developers can conveiently run golangci-lint locally like it runs in the CI. golangci-lint is also run as part of the more general 'make lint'. Signed-off-by: Michael Adam <obnox@samba.org>
This change expands the section about regression testing in the developer guide by adding information about how to run linters locally. Signed-off-by: Michael Adam <obnox@samba.org>
CI: extract 'markdownlint' and 'golangci-lint' make targets from the ci workflows
mgr: Wait for builtin mgr pool to exist before enabling stretch
Signed-off-by: subhamkrai <srai@redhat.com>
ci: Increase rgw multisite test timeout for s3 client call
The development guide mentioned that commit messages should be lengthy which has a negative connotation of meaning long-winded. This change rewords the corresponding part to sound more positive. Signed-off-by: Michael Adam <obnox@samba.org>
docs: slight rewording in development guide
subhamkrai
approved these changes
Mar 3, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch