From 425efd8dd0a63d59c9fcc09c8c713dc87ac17e08 Mon Sep 17 00:00:00 2001 From: Keith Valin Date: Tue, 11 Feb 2025 12:05:15 -0500 Subject: [PATCH 1/4] Feat(ci): Add workflows referencing Zathras definitions --- .github/workflows/check_review_label.yml | 14 ++++++++++++++ .github/workflows/issue_tagging.yml | 21 +++++++++++++++++++++ .github/workflows/verify_pr_requirement.yml | 18 ++++++++++++++++++ 3 files changed, 53 insertions(+) create mode 100644 .github/workflows/check_review_label.yml create mode 100644 .github/workflows/issue_tagging.yml create mode 100644 .github/workflows/verify_pr_requirement.yml diff --git a/.github/workflows/check_review_label.yml b/.github/workflows/check_review_label.yml new file mode 100644 index 0000000..1ea36af --- /dev/null +++ b/.github/workflows/check_review_label.yml @@ -0,0 +1,14 @@ +on: + pull_request: + types: + - opened + - labeled + +env: + TARGET_LABEL: "group_review_lgtm" + +jobs: + check_review_label: + runs-on: ubuntu-latest + steps: + - uses: redhat-performance/zathras/.github/workflows/check_review_label.yml@main \ No newline at end of file diff --git a/.github/workflows/issue_tagging.yml b/.github/workflows/issue_tagging.yml new file mode 100644 index 0000000..6e05d22 --- /dev/null +++ b/.github/workflows/issue_tagging.yml @@ -0,0 +1,21 @@ +on: + pull_request_target: + types: + - review_requested + pull_request_review: + types: + - submitted + +permissions: + issues: write + +env: + ISSUE_STATE: pr_inprogress + REMOVE_ISSUES: --remove-label pr_approved --remove-label pr_review --remove-label pr_inprogress + GH_TOKEN: ${{ github.token }} + +jobs: + check_review_label: + runs-on: ubuntu-latest + steps: + - uses: redhat-performance/zathras/.github/workflows/issue_tagging.yml@main \ No newline at end of file diff --git a/.github/workflows/verify_pr_requirement.yml b/.github/workflows/verify_pr_requirement.yml new file mode 100644 index 0000000..10f4503 --- /dev/null +++ b/.github/workflows/verify_pr_requirement.yml @@ -0,0 +1,18 @@ +on: + workflow_call: + pull_request: + types: + - opened + - edited + branches: + - main + +permissions: + contents: read + pull-requests: write # Need write to make comments + +jobs: + check_review_label: + runs-on: ubuntu-latest + steps: + - uses: redhat-performance/zathras/.github/workflows/verify_pr_requirements.yml@main \ No newline at end of file From 6ab3e508a066531ad43e86960eca73afbf4f12c8 Mon Sep 17 00:00:00 2001 From: Keith Valin Date: Tue, 11 Feb 2025 15:42:42 -0500 Subject: [PATCH 2/4] Fix(ci): Fix yaml issue --- .github/workflows/check_review_label.yml | 4 +--- .github/workflows/issue_tagging.yml | 4 +--- .github/workflows/verify_pr_requirement.yml | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check_review_label.yml b/.github/workflows/check_review_label.yml index 1ea36af..3ade7e6 100644 --- a/.github/workflows/check_review_label.yml +++ b/.github/workflows/check_review_label.yml @@ -9,6 +9,4 @@ env: jobs: check_review_label: - runs-on: ubuntu-latest - steps: - - uses: redhat-performance/zathras/.github/workflows/check_review_label.yml@main \ No newline at end of file + uses: redhat-performance/zathras/.github/workflows/check_review_label.yml@main \ No newline at end of file diff --git a/.github/workflows/issue_tagging.yml b/.github/workflows/issue_tagging.yml index 6e05d22..77fb3b3 100644 --- a/.github/workflows/issue_tagging.yml +++ b/.github/workflows/issue_tagging.yml @@ -16,6 +16,4 @@ env: jobs: check_review_label: - runs-on: ubuntu-latest - steps: - - uses: redhat-performance/zathras/.github/workflows/issue_tagging.yml@main \ No newline at end of file + uses: redhat-performance/zathras/.github/workflows/issue_tagging.yml@main \ No newline at end of file diff --git a/.github/workflows/verify_pr_requirement.yml b/.github/workflows/verify_pr_requirement.yml index 10f4503..450f1bc 100644 --- a/.github/workflows/verify_pr_requirement.yml +++ b/.github/workflows/verify_pr_requirement.yml @@ -13,6 +13,4 @@ permissions: jobs: check_review_label: - runs-on: ubuntu-latest - steps: - - uses: redhat-performance/zathras/.github/workflows/verify_pr_requirements.yml@main \ No newline at end of file + uses: redhat-performance/zathras/.github/workflows/verify_pr_requirements.yml@main \ No newline at end of file From 0d316207e5fa8a0e10027df9b3bbd9cb79aa4e18 Mon Sep 17 00:00:00 2001 From: Keith Valin Date: Wed, 12 Feb 2025 10:47:09 -0500 Subject: [PATCH 3/4] Fix(ci): Filename typos --- .../{check_review_label.yml => check_review_label.yaml} | 2 +- .github/workflows/{issue_tagging.yml => issue_tagging.yaml} | 2 +- .../{verify_pr_requirement.yml => verify_pr_requirement.yaml} | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename .github/workflows/{check_review_label.yml => check_review_label.yaml} (91%) rename .github/workflows/{issue_tagging.yml => issue_tagging.yaml} (96%) rename .github/workflows/{verify_pr_requirement.yml => verify_pr_requirement.yaml} (92%) diff --git a/.github/workflows/check_review_label.yml b/.github/workflows/check_review_label.yaml similarity index 91% rename from .github/workflows/check_review_label.yml rename to .github/workflows/check_review_label.yaml index 3ade7e6..ee8a144 100644 --- a/.github/workflows/check_review_label.yml +++ b/.github/workflows/check_review_label.yaml @@ -9,4 +9,4 @@ env: jobs: check_review_label: - uses: redhat-performance/zathras/.github/workflows/check_review_label.yml@main \ No newline at end of file + uses: redhat-performance/zathras/.github/workflows/check_review_label.yaml@main \ No newline at end of file diff --git a/.github/workflows/issue_tagging.yml b/.github/workflows/issue_tagging.yaml similarity index 96% rename from .github/workflows/issue_tagging.yml rename to .github/workflows/issue_tagging.yaml index 77fb3b3..dcc467e 100644 --- a/.github/workflows/issue_tagging.yml +++ b/.github/workflows/issue_tagging.yaml @@ -16,4 +16,4 @@ env: jobs: check_review_label: - uses: redhat-performance/zathras/.github/workflows/issue_tagging.yml@main \ No newline at end of file + uses: redhat-performance/zathras/.github/workflows/issue_tagging.yaml@main \ No newline at end of file diff --git a/.github/workflows/verify_pr_requirement.yml b/.github/workflows/verify_pr_requirement.yaml similarity index 92% rename from .github/workflows/verify_pr_requirement.yml rename to .github/workflows/verify_pr_requirement.yaml index 450f1bc..2f6540d 100644 --- a/.github/workflows/verify_pr_requirement.yml +++ b/.github/workflows/verify_pr_requirement.yaml @@ -13,4 +13,4 @@ permissions: jobs: check_review_label: - uses: redhat-performance/zathras/.github/workflows/verify_pr_requirements.yml@main \ No newline at end of file + uses: redhat-performance/zathras/.github/workflows/verify_pr_requirements.yaml@main \ No newline at end of file From 8c23581dbb3b73a9350052fa1047ba517c315a9d Mon Sep 17 00:00:00 2001 From: Keith Valin Date: Wed, 12 Feb 2025 10:48:58 -0500 Subject: [PATCH 4/4] Fix(ci): Add names to workflows to make it easier to read --- .github/workflows/check_review_label.yaml | 2 ++ .github/workflows/issue_tagging.yaml | 2 ++ .github/workflows/verify_pr_requirement.yaml | 2 ++ 3 files changed, 6 insertions(+) diff --git a/.github/workflows/check_review_label.yaml b/.github/workflows/check_review_label.yaml index ee8a144..ef10137 100644 --- a/.github/workflows/check_review_label.yaml +++ b/.github/workflows/check_review_label.yaml @@ -1,3 +1,5 @@ +name: Check for Group Review label + on: pull_request: types: diff --git a/.github/workflows/issue_tagging.yaml b/.github/workflows/issue_tagging.yaml index dcc467e..f1a8f60 100644 --- a/.github/workflows/issue_tagging.yaml +++ b/.github/workflows/issue_tagging.yaml @@ -1,3 +1,5 @@ +name: Update Parent issue + on: pull_request_target: types: diff --git a/.github/workflows/verify_pr_requirement.yaml b/.github/workflows/verify_pr_requirement.yaml index 2f6540d..7b6b5d7 100644 --- a/.github/workflows/verify_pr_requirement.yaml +++ b/.github/workflows/verify_pr_requirement.yaml @@ -1,3 +1,5 @@ +name: Verify PR requirements + on: workflow_call: pull_request: