Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the Node.js code to use node-redis rather than ioredis #27

Open
simonprickett opened this issue Oct 5, 2022 · 21 comments
Open

Comments

@simonprickett
Copy link
Contributor

simonprickett commented Oct 5, 2022

This application was written using the ioredis client. Rewrite it to use the latest node-redis client and update the README.md file as needed.

You should also use import statements instead of require (see this article for info), and use top level await.

Add an engines section to package.json (information here) to specify that the code requires Node 14.8 or higher. You could also additionally add an .nvmrc file.

@simonprickett simonprickett added enhancement New feature or request hacktoberfest Hacktoberfest 2022 labels Oct 5, 2022
@Ananyamadhu08
Copy link

Ananyamadhu08 commented Oct 5, 2022

Hey, I would like to work on this. @simonprickett @SuzeShardlow

@SuzeShardlow
Copy link
Contributor

Hi @Ananyamadhu08, I've assigned this to you. Please make sure you check our guidelines, and we look forward to receiving your PR in the next couple of days. Have fun!

https://redis.io/community/hacktoberfest/

@rowantrollope
Copy link

@SuzeShardlow @simonprickett - I'd like to work on this as well. I see its been assigned to Ananya - is it first come first serve, or can multiple people work these?

@simonprickett
Copy link
Contributor Author

@rowantrollope Hi there - thanks for your interest... it's one at a time, but if no PR is received within a couple of days we'll recycle this back into the pool. We're also looking to get as wide as possible contribution so we're only assigning people a 2nd issue if others don't take one first. I've just assigned you a node-redis issue, and we look forward to seeing your contribution there. Thanks!

@rowantrollope
Copy link

rowantrollope commented Oct 7, 2022 via email

@SuzeShardlow
Copy link
Contributor

Hi @Ananyamadhu08, how are you getting on with this? :)

@rowantrollope
Copy link

rowantrollope commented Oct 10, 2022 via email

@Ananyamadhu08
Copy link

Hello @SuzeShardlow I'm still working on this please give me a few more days I'll submit the PR asap.

@sailingwithsandeep
Copy link

Hello, I would love to work on this. @SuzeShardlow @simonprickett (if it's still available)

@SuzeShardlow
Copy link
Contributor

Hi @sailingwithsandeep, this is not available at the moment but I have assigned you a different one that you asked for :) please check your notifications.

@SuzeShardlow
Copy link
Contributor

This issue is currently assigned to @Ananyamadhu08.

@SuzeShardlow
Copy link
Contributor

Hi @Ananyamadhu08, how are you doing with this? :)

@SuzeShardlow
Copy link
Contributor

This issue is available and up for grabs. Please tag me and @simonprickett if you would like to work on it.

@sailingwithsandeep
Copy link

Hello, I would love to work on this. @SuzeShardlow @simonprickett

@SuzeShardlow
Copy link
Contributor

Hi @sailingwithsandeep, we are allocating one issue per person to ensure the most people can have a chance at getting a Hacktoberfest PR :) you have already had one of our issues so I will leave this one available for others :)

@SuzeShardlow
Copy link
Contributor

This issue is available and up for grabs. Please tag me and @simonprickett if you would like to work on it.

@SuzeShardlow
Copy link
Contributor

This issue is available and up for grabs. Please tag me and @simonprickett if you would like to work on it :)

@Siddharth9890
Copy link

Siddharth9890 commented Oct 5, 2023

hi @SuzeShardlow @simonprickett can i work on this?

@simonprickett
Copy link
Contributor Author

@Siddharth9890 thanks for your interest, but we're not taking part in Hacktoberfest this year.

@simonprickett simonprickett removed the hacktoberfest Hacktoberfest 2022 label Oct 5, 2023
@Siddharth9890
Copy link

hey @simonprickett i would still like to contribute to it if possible ?

@simonprickett
Copy link
Contributor Author

@Siddharth9890 if you'd like to work with this codebase, I'd recommend forking it and taking it your own direction... I plan to do a lot of work here to update it for new Redis features in the not too distant future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants