-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the Node.js code to use node-redis rather than ioredis #27
Comments
Hey, I would like to work on this. @simonprickett @SuzeShardlow |
Hi @Ananyamadhu08, I've assigned this to you. Please make sure you check our guidelines, and we look forward to receiving your PR in the next couple of days. Have fun! |
@SuzeShardlow @simonprickett - I'd like to work on this as well. I see its been assigned to Ananya - is it first come first serve, or can multiple people work these? |
@rowantrollope Hi there - thanks for your interest... it's one at a time, but if no PR is received within a couple of days we'll recycle this back into the pool. We're also looking to get as wide as possible contribution so we're only assigning people a 2nd issue if others don't take one first. I've just assigned you a node-redis issue, and we look forward to seeing your contribution there. Thanks! |
Thanks!
Sent via Superhuman iOS ( ***@***.*** )
…On Fri, Oct 7 2022 at 9:21 AM, Simon Prickett < ***@***.*** > wrote:
@rowantrollope ( https://github.com/rowantrollope ) Hi there - thanks for
your interest... it's one at a time, but if no PR is received within a
couple of days we'll recycle this back into the pool. We're also looking
to get as wide as possible contribution so we're only assigning people a
2nd issue if others don't take one first. I've just assigned you a
node-redis issue, and we look forward to seeing your contribution there.
Thanks!
—
Reply to this email directly, view it on GitHub (
#27 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ACXKL5NDOND2QGPACEAXWELWCBEZ7ANCNFSM6AAAAAAQ5YUWYE
).
You are receiving this because you were mentioned. Message ID: <redis-developer/redis-kaboom-rpg/issues/27/1271796841
@ github. com>
|
Hi @Ananyamadhu08, how are you getting on with this? :) |
Unfortunately my father passed so I have been unable to finish this :( ok if you pass to someone else
Sent via Superhuman iOS ( ***@***.*** )
…On Mon, Oct 10 2022 at 10:44 AM, Suze Shardlow < ***@***.*** > wrote:
Hi @Ananyamadhu08 ( https://github.com/Ananyamadhu08 ) , how are you
getting on with this? :)
—
Reply to this email directly, view it on GitHub (
#27 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ACXKL5IAHDXGGCFAZHM7BFLWCQTV7ANCNFSM6AAAAAAQ5YUWYE
).
You are receiving this because you were mentioned. Message ID: <redis-developer/redis-kaboom-rpg/issues/27/1273426409
@ github. com>
|
Hello @SuzeShardlow I'm still working on this please give me a few more days I'll submit the PR asap. |
Hello, I would love to work on this. @SuzeShardlow @simonprickett (if it's still available) |
Hi @sailingwithsandeep, this is not available at the moment but I have assigned you a different one that you asked for :) please check your notifications. |
This issue is currently assigned to @Ananyamadhu08. |
Hi @Ananyamadhu08, how are you doing with this? :) |
This issue is available and up for grabs. Please tag me and @simonprickett if you would like to work on it. |
Hello, I would love to work on this. @SuzeShardlow @simonprickett |
Hi @sailingwithsandeep, we are allocating one issue per person to ensure the most people can have a chance at getting a Hacktoberfest PR :) you have already had one of our issues so I will leave this one available for others :) |
This issue is available and up for grabs. Please tag me and @simonprickett if you would like to work on it. |
This issue is available and up for grabs. Please tag me and @simonprickett if you would like to work on it :) |
hi @SuzeShardlow @simonprickett can i work on this? |
@Siddharth9890 thanks for your interest, but we're not taking part in Hacktoberfest this year. |
hey @simonprickett i would still like to contribute to it if possible ? |
@Siddharth9890 if you'd like to work with this codebase, I'd recommend forking it and taking it your own direction... I plan to do a lot of work here to update it for new Redis features in the not too distant future. |
This application was written using the ioredis client. Rewrite it to use the latest node-redis client and update the
README.md
file as needed.You should also use
import
statements instead ofrequire
(see this article for info), and use top levelawait
.Add an
engines
section topackage.json
(information here) to specify that the code requires Node 14.8 or higher. You could also additionally add an.nvmrc
file.The text was updated successfully, but these errors were encountered: