Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FB] Using abc.ABC instead of Protocol for ModelProtocol #13

Open
jacopoabramo opened this issue Jan 29, 2025 · 0 comments
Open

[FB] Using abc.ABC instead of Protocol for ModelProtocol #13

jacopoabramo opened this issue Jan 29, 2025 · 0 comments
Labels
feedback-requested I would like somebody else's opinion on this

Comments

@jacopoabramo
Copy link
Collaborator

While working on redsun-simulator, it occurred to me that I'm starting to implement the same pattern for all devices, and that is using the Configurable protocol in all of them. I also added the possibility to read/change the configuration of the ModelInfo. Technically this should be an optional Protocol in bluesky (like everything else) but it might be worth to use as a baseline abstract class. It also would enforce the usage of a standardized __init__ function which seems more coherent with the usage.

An alternative would also be using ModelProtocol as a mixin, but I fear it might be misunderstood.

@jacopoabramo jacopoabramo added the feedback-requested I would like somebody else's opinion on this label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback-requested I would like somebody else's opinion on this
Projects
None yet
Development

No branches or pull requests

1 participant