Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dose this lib support indian amazon also ? #58

Open
redtoad opened this issue Jul 6, 2015 · 10 comments
Open

Dose this lib support indian amazon also ? #58

redtoad opened this issue Jul 6, 2015 · 10 comments
Labels
0.2.8 enhancement New feature or request major
Milestone

Comments

@redtoad
Copy link
Owner

redtoad commented Jul 6, 2015

Originally reported by Anonymous


because i am getting below issue while using in locale

In [4]: api = API(locale='in')
---------------------------------------------------------------------------
UnknownLocale                             Traceback (most recent call last)
<ipython-input-4-02f224675a03> in <module>()
----> 1 api = API(locale='in')

/usr/local/lib/python2.7/site-packages/amazonproduct/api.pyc in __init__(self, access_key_id, secret_access_key, locale, associate_tag, processor, cfg)
    153             self.host = HOSTS[self.locale]
    154         except KeyError:
--> 155             raise UnknownLocale(locale)
    156 
    157         # GAE does not allow timeouts to be specified manually

UnknownLocale: in```

----------------------------------------
- Bitbucket: https://bitbucket.org/basti/python-amazon-product-api/issue/58
@redtoad
Copy link
Owner Author

redtoad commented Jul 7, 2015

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)


Supporting this is quickly done. However, before I intergrate anything I would like to have some tests. Do you feel up for it?

@redtoad
Copy link
Owner Author

redtoad commented Aug 8, 2015

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)


I don't have an Amazon account for IN. Without a volunteer this issue cannot be solved.

@redtoad
Copy link
Owner Author

redtoad commented Dec 30, 2015

Original comment by ARUN KUMAR R (Bitbucket: arunkmarcse, GitHub: arunkmarcse)


Hi Sebastian,
I have an amazon affiliate account for Amazon IN. I can help you in performing tests for this. Can you please go ahead and support 'IN' locale as well.

@redtoad
Copy link
Owner Author

redtoad commented Dec 30, 2015

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)


I'm very happy to accept pull requests ;-)

You can generate the missing XML files for the tests using

py.test --locale=in --refetch=missing tests/test_xml_responses.py

Let me know if you need help.

@redtoad
Copy link
Owner Author

redtoad commented Dec 30, 2015

Original comment by ARUN KUMAR R (Bitbucket: arunkmarcse, GitHub: arunkmarcse)


Good.. I thought i just need to clone the source code. Uncomment the below line in the file (python-amazon-product-api/amazonproduct/api.py )

'in': 'webservices.amazon.in',

And then run "python setup.py install"

Then, i should pass my access key and secret key with locale as "in". I thought this will work for me.

I'm not pretty sure about what "missing XML files" will do. Please help in this.

@redtoad
Copy link
Owner Author

redtoad commented Dec 30, 2015

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)


The tests need to pass as well for any change. Try running

#!

python setup.py test

See also http://python-amazon-product-api.readthedocs.org/en/stable/contributing.html#running-the-tests

@redtoad
Copy link
Owner Author

redtoad commented Dec 30, 2015

Original comment by ARUN KUMAR R (Bitbucket: arunkmarcse, GitHub: arunkmarcse)


Thanks. I have just uncommented the line 'in': 'webservices.amazon.in', and ran the below two test case commands. I have attached the log file of it. Please check and let me know whether it is fine.

py.test --locale=in --refetch=missing tests/test_xml_responses.py -----> test_xml_responses.log
python setup.py test -------------> setup-test.log

@redtoad
Copy link
Owner Author

redtoad commented Jan 8, 2016

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)


Can you please send me a pull request with your changes? I'd ike to make sure that I'm seeing the same thing over here.

@redtoad
Copy link
Owner Author

redtoad commented Jan 9, 2018

Original comment by Dibya Chakravorty (Bitbucket: DibyaC, GitHub: Unknown)


Hi Sebastian, I have been using this package for a while now. It's very useful, thanks for creating it. I recently wanted to add amazon.in support to my website (which uses the package) and came across this issue. I do have an amazon.in affiliate account. If you could outline the changes that I need to make to make the package work for amazon.in and how to run tests, that would be great. If everything works out, I can send you a pull request shortly.

@redtoad
Copy link
Owner Author

redtoad commented Mar 5, 2018

Original comment by Harun Yasar (Bitbucket: harunyasar, GitHub: harunyasar)


When will be supported? Do you have any plan?

@redtoad redtoad added major enhancement New feature or request 0.2.8 labels Jul 9, 2018
@redtoad redtoad added this to the 0.3 milestone Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2.8 enhancement New feature or request major
Projects
None yet
Development

No branches or pull requests

1 participant