From ad1e6db0942ae1eab18cc73bf32c16db81c57a8a Mon Sep 17 00:00:00 2001 From: Ranjib Dey Date: Sat, 15 Jan 2022 23:11:24 -0800 Subject: [PATCH 1/2] take lock before reading map value --- pwm/noop_driver.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pwm/noop_driver.go b/pwm/noop_driver.go index ac19928..163b2ea 100644 --- a/pwm/noop_driver.go +++ b/pwm/noop_driver.go @@ -25,7 +25,10 @@ func Noop() (Driver, *recorder) { return nil }, readFile: func(f string) ([]byte, error) { - if _, ok := rec.values[f]; !ok { + rec.mu.Lock() + _, ok := rec.values[f] + rec.mu.Unlock() + if !ok { return []byte{}, nil } return rec.values[f], nil From 03ca8c9867550cc91d7e5c224f88183ccc8fe596 Mon Sep 17 00:00:00 2001 From: Ranjib Dey Date: Sat, 15 Jan 2022 23:16:43 -0800 Subject: [PATCH 2/2] turn on race detector during test --- .github/workflows/go.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 7136518..7972bd7 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -9,5 +9,5 @@ jobs: with: go-version: '^1.16.1' - uses: codecov/codecov-action@v1 - - run: go test ./... + - run: go test -cover -race ./... - run: go build ./...