refactor(ProxyGeneratorInterface): Use class as input, remove dependency on ObjectToObjectMetadata.

Author: priyadi

src/Transformer/ObjectToObjectMetadata/Implementation/ObjectToObjectMetadataFactory.php

@@ -333,7 +333,7 @@ public function createObjectToObjectMetadata(
 
         try {
             $proxySpecification = $this->proxyGenerator
-                ->generateTargetProxy($objectToObjectMetadata);
+                ->generateProxy($targetClass);
 
             // determine if the constructor contains eager properties. if it
             // does, then the constructor is eager

src/Transformer/Proxy/Exception/ProxyNotSupportedException.php

@@ -14,19 +14,20 @@
 namespace Rekalogika\Mapper\Transformer\Proxy\Exception;
 
 use Rekalogika\Mapper\Exception\RuntimeException;
-use Rekalogika\Mapper\Transformer\ObjectToObjectMetadata\ObjectToObjectMetadata;
 
 class ProxyNotSupportedException extends RuntimeException
 {
     private string $reason;
 
-    public function __construct(ObjectToObjectMetadata $metadata, \Throwable $previous)
+    /**
+     * @param class-string $class
+     */
+    public function __construct(string $class, \Throwable $previous)
     {
         parent::__construct(
             sprintf(
-                'Creating target proxy is not supported for target class "%s" and source class "%s"',
-                $metadata->getTargetClass(),
-                $metadata->getSourceClass()
+                'Creating a proxy for class "%s" is not supported.',
+                $class
             ),
             previous: $previous
         );

src/Transformer/Proxy/Implementation/ProxyGenerator.php

@@ -13,7 +13,6 @@
 
 namespace Rekalogika\Mapper\Transformer\Proxy\Implementation;
 
-use Rekalogika\Mapper\Transformer\ObjectToObjectMetadata\ObjectToObjectMetadata;
 use Rekalogika\Mapper\Transformer\Proxy\Exception\ProxyNotSupportedException;
 use Rekalogika\Mapper\Transformer\Proxy\ProxyGeneratorInterface;
 use Rekalogika\Mapper\Transformer\Proxy\ProxySpecification;
@@ -22,45 +21,40 @@
 
 final class ProxyGenerator implements ProxyGeneratorInterface
 {
-    public function generateTargetProxy(ObjectToObjectMetadata $metadata): ProxySpecification
+    public function generateProxy(string $class): ProxySpecification
     {
-        $sourceClass = $metadata->getSourceClass();
-        $targetClass = $metadata->getTargetClass();
-
         /** @var class-string */
-        $proxyClass = $this->generateProxyClassName($sourceClass, $targetClass);
+        $proxyClass = $this->generateProxyClassName($class);
 
         try {
-            $proxyCode = $this->generateProxyCode($sourceClass, $targetClass);
+            $proxyCode = $this->generateProxyCode($class);
         } catch (LogicException $e) {
-            throw new ProxyNotSupportedException($metadata, $e);
+            throw new ProxyNotSupportedException($class, $e);
         }
 
         return new ProxySpecification($proxyClass, $proxyCode);
     }
 
     /**
-     * @param class-string $sourceClass
-     * @param class-string $targetClass
+     * @param class-string $class
      * @return string
      */
-    private function generateProxyClassName(string $sourceClass, string $targetClass): string
+    private function generateProxyClassName(string $class): string
     {
         return sprintf(
             'Rekalogika\Mapper\Generated\__CG__\%s',
-            $targetClass
+            $class
         );
     }
 
     /**
-     * @param class-string $sourceClass
-     * @param class-string $targetClass
+     * @param class-string $class
      * @return string
      */
-    private function generateProxyCode(string $sourceClass, string $targetClass): string
+    private function generateProxyCode(string $class): string
     {
-        $proxyClass = $this->generateProxyClassName($sourceClass, $targetClass);
-        $targetReflection = new \ReflectionClass($targetClass);
+        $proxyClass = $this->generateProxyClassName($class);
+        $targetReflection = new \ReflectionClass($class);
 
         // get proxy class name & namespace
         $shortName = preg_replace('/.*\\\\/', '', $proxyClass);

src/Transformer/Proxy/ProxyGeneratorInterface.php

@@ -13,15 +13,13 @@
 
 namespace Rekalogika\Mapper\Transformer\Proxy;
 
-use Rekalogika\Mapper\Transformer\ObjectToObjectMetadata\ObjectToObjectMetadata;
 use Rekalogika\Mapper\Transformer\Proxy\Exception\ProxyNotSupportedException;
 
 interface ProxyGeneratorInterface
 {
     /**
+     * @param class-string $class
      * @throws ProxyNotSupportedException
      */
-    public function generateTargetProxy(
-        ObjectToObjectMetadata $metadata
-    ): ProxySpecification;
+    public function generateProxy(string $class): ProxySpecification;
 }