Skip to content

Commit 324f3f2

Browse files
authored
fix: static analysis fixes (#49)
1 parent 6f87e4a commit 324f3f2

File tree

3 files changed

+24
-4
lines changed

3 files changed

+24
-4
lines changed

src/CustomMapper/Implementation/PropertyMapperResolver.php

+6-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,12 @@ public function getPropertyMapper(
6666
}
6767
} while ($sourceClassReflection = $sourceClassReflection->getParentClass());
6868

69-
foreach (class_implements($targetClass) as $interface) {
69+
$interfaces = class_implements($sourceClass);
70+
if ($interfaces === false) {
71+
return null;
72+
}
73+
74+
foreach ($interfaces as $interface) {
7075
if (isset($propertyMappers[$interface])) {
7176
return $propertyMappers[$interface];
7277
}

src/CustomMapper/ObjectMapperTable.php

+6-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,12 @@ public function getObjectMapper(
7373
}
7474
} while ($sourceClassReflection = $sourceClassReflection->getParentClass());
7575

76-
foreach (class_implements($targetClass) as $interface) {
76+
$interfaces = class_implements($sourceClass);
77+
if ($interfaces === false) {
78+
return null;
79+
}
80+
81+
foreach ($interfaces as $interface) {
7782
if (isset($propertyMappers[$interface])) {
7883
return $propertyMappers[$interface];
7984
}

src/Util/TypeUtil.php

+12-2
Original file line numberDiff line numberDiff line change
@@ -416,11 +416,21 @@ private static function getAllClassesFromObject(
416416
$class = is_object($objectOrClass) ? $objectOrClass::class : $objectOrClass;
417417
$classes[] = $class;
418418

419-
foreach (class_parents($class) as $parentClass) {
419+
$parents = class_parents($class);
420+
if ($parents === false) {
421+
$parents = [];
422+
}
423+
424+
foreach ($parents as $parentClass) {
420425
$classes[] = $parentClass;
421426
}
422427

423-
foreach (class_implements($class) as $interface) {
428+
$interfaces = class_implements($class);
429+
if ($interfaces === false) {
430+
$interfaces = [];
431+
}
432+
433+
foreach ($interfaces as $interface) {
424434
$classes[] = $interface;
425435
}
426436

0 commit comments

Comments
 (0)