refactor(MappingFactory): Separate cache warmer from WarmableMappingFactory.

Author: priyadi

CHANGELOG.md

@@ -13,6 +13,8 @@
 * fix(`ObjectToObjectMetadataFactory`): If the target is not writable, skip the
   mapping.
 * feat(`Profiler`): Show mapping table.
+* refactor(`MappingFactory`): Separate cache warmer from
+  `WarmableMappingFactory`.
 
 ## 0.7.2
 

config/services.php

@@ -22,6 +22,7 @@
 use Rekalogika\Mapper\MainTransformer\MainTransformer;
 use Rekalogika\Mapper\Mapper;
 use Rekalogika\Mapper\MapperInterface;
+use Rekalogika\Mapper\Mapping\Implementation\MappingCacheWarmer;
 use Rekalogika\Mapper\Mapping\Implementation\MappingFactory;
 use Rekalogika\Mapper\Mapping\Implementation\WarmableMappingFactory;
 use Rekalogika\Mapper\Mapping\MappingFactoryInterface;
@@ -201,10 +202,18 @@
 
     $services
         ->set('rekalogika.mapper.mapping_factory.caching', WarmableMappingFactory::class)
-        ->decorate('rekalogika.mapper.mapping_factory', null, 500)
+        ->decorate('rekalogika.mapper.mapping_factory', null, 100)
         ->args([
-            service('rekalogika.mapper.mapping_factory.caching.inner'),
+            service('.inner'),
             service('kernel')
+        ]);
+
+    # mapping cache warmer
+
+    $services
+        ->set('rekalogika.mapper.mapping_factory.warmer', MappingCacheWarmer::class)
+        ->args([
+            service('rekalogika.mapper.mapping_factory.caching'),
         ])
         ->tag('kernel.cache_warmer');
 

src/DependencyInjection/CompilerPass/DebugPass.php

@@ -67,7 +67,7 @@ public function process(ContainerBuilder $container)
         $serviceId = 'rekalogika.mapper.mapping_factory';
         $decoratedService = $container->getDefinition($serviceId);
         $container->register('debug.' . $serviceId, TraceableMappingFactory::class)
-            ->setDecoratedService($serviceId, null, 100)
+            ->setDecoratedService($serviceId, null, 50)
             ->setArguments([
                 $decoratedService,
                 $dataCollector,

src/Mapping/Implementation/MappingCacheWarmer.php

@@ -0,0 +1,36 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of rekalogika/mapper package.
+ *
+ * (c) Priyadi Iman Nurcahyo <https://rekalogika.dev>
+ *
+ * For the full copyright and license information, please view the LICENSE file
+ * that was distributed with this source code.
+ */
+
+namespace Rekalogika\Mapper\Mapping\Implementation;
+
+use Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerInterface;
+
+final class MappingCacheWarmer implements CacheWarmerInterface
+{
+    public function __construct(
+        private WarmableMappingFactory $warmableMappingFactory,
+    ) {
+    }
+
+    public function isOptional(): bool
+    {
+        return false;
+    }
+
+    public function warmUp(string $cacheDir, ?string $buildDir = null): array
+    {
+        $this->warmableMappingFactory->warmUp();
+
+        return [];
+    }
+}

src/Mapping/Implementation/WarmableMappingFactory.php

@@ -16,13 +16,10 @@
 use Rekalogika\Mapper\Exception\UnexpectedValueException;
 use Rekalogika\Mapper\Mapping\Mapping;
 use Rekalogika\Mapper\Mapping\MappingFactoryInterface;
-use Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerInterface;
 use Symfony\Component\HttpKernel\KernelInterface;
 use Symfony\Component\VarExporter\VarExporter;
 
-final class WarmableMappingFactory implements
-    MappingFactoryInterface,
-    CacheWarmerInterface
+final class WarmableMappingFactory implements MappingFactoryInterface
 {
     public const CACHE_FILE = 'rekalogika_mapper_mapping.php';
 
@@ -41,7 +38,7 @@ private function getMappingFromInnerFactory(): Mapping
 
     private function warmUpAndGetMapping(): Mapping
     {
-        $this->warmUp($this->kernel->getCacheDir(), $this->kernel->getBuildDir());
+        $this->warmUp();
 
         return $this->getMappingFromInnerFactory();
     }
@@ -75,21 +72,14 @@ public function getMapping(): Mapping
         return $this->mapping = $result;
     }
 
-    public function isOptional(): bool
-    {
-        return false;
-    }
-
     private function getCacheFilePath(): string
     {
         return $this->kernel->getBuildDir() . '/' . self::CACHE_FILE;
     }
 
-    public function warmUp(string $cacheDir, ?string $buildDir = null): array
+    public function warmUp(): void
     {
         $mapping = VarExporter::export($this->realMappingFactory->getMapping());
         file_put_contents($this->getCacheFilePath(), '<?php return ' . $mapping . ';');
-
-        return [];
     }
 }