Skip to content

Commit

Permalink
Merge pull request #723 from rfcx/bug/CE-1183-user-unable-to-select-t…
Browse files Browse the repository at this point in the history
…he-month-of-January-on-the-filters

CE-1183 User is able to select the month of Jenuary in the recordings filters
  • Loading branch information
rassokhina-e authored Aug 10, 2021
2 parents 5a5452c + 7a91cae commit a6393ba
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Arbimon Release Notes

## v3.0.35 - August XX, 2021

Resolved issues:

- CE-1183 Fixed filter in the recordings page. The user is able to select the month of January

## v3.0.34 - August XX, 2021

New features:
Expand Down
9 changes: 9 additions & 0 deletions TEST_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
# Arbimon Test Notes
Test Notes are used to list what pages / components / features / user flows are affected by each update.

## v3.0.35

- CE-1183 Fixed filter in the recordings page. The user is able to select the month of January
- The user selects "Date and Time" filter for month of January. The user sees the recordings with the selected date.
- The user selects "Range", "Date and Time" filters for month of January. The user sees the recordings with the selected date.
- The user selects "Date and Time" filter for month of February. The user sees the recordings with the selected date.
- Setting the "Range" filter in February, while keeping January in "Date and Time" filter. The result supposed to be zero records, because January is outside the range.
- Setting the "Range" filter in February, while setting month of March in "Date and Time" filter. The result is no records, because March is outside the Range.

## v3.0.34

- CE-1101 A search bar is updated for projects across Arbimon
Expand Down
3 changes: 1 addition & 2 deletions app/model/recordings.js
Original file line number Diff line number Diff line change
Expand Up @@ -1159,8 +1159,7 @@ var Recordings = {
constraints.push('YEAR(r.datetime) IN (?)');
data.push(parameters.years);
}

if(parameters.months) {
if(parameters.months !== undefined) {
constraints.push('MONTH(r.datetime) IN (?)');
data.push((parameters.months instanceof Array) ?
parameters.months.map(function(m) { return parseInt(m)+1; }) :
Expand Down

0 comments on commit a6393ba

Please sign in to comment.