From 7a91caecb2fe89864ab2589282b55d8fdd205119 Mon Sep 17 00:00:00 2001 From: Evgeniia Rassokhina Date: Mon, 9 Aug 2021 12:33:31 +0300 Subject: [PATCH] CE-1183 User is able to select the month of Jenuary in the recordings filters --- CHANGELOG.md | 6 ++++++ TEST_NOTES.md | 9 +++++++++ app/model/recordings.js | 3 +-- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e08133273..ad552f40f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Arbimon Release Notes +## v3.0.35 - August XX, 2021 + +Resolved issues: + +- CE-1183 Fixed filter in the recordings page. The user is able to select the month of January + ## v3.0.34 - August XX, 2021 New features: diff --git a/TEST_NOTES.md b/TEST_NOTES.md index 6c3b34261..0d9a0b77f 100644 --- a/TEST_NOTES.md +++ b/TEST_NOTES.md @@ -1,6 +1,15 @@ # Arbimon Test Notes Test Notes are used to list what pages / components / features / user flows are affected by each update. +## v3.0.35 + +- CE-1183 Fixed filter in the recordings page. The user is able to select the month of January + - The user selects "Date and Time" filter for month of January. The user sees the recordings with the selected date. + - The user selects "Range", "Date and Time" filters for month of January. The user sees the recordings with the selected date. + - The user selects "Date and Time" filter for month of February. The user sees the recordings with the selected date. + - Setting the "Range" filter in February, while keeping January in "Date and Time" filter. The result supposed to be zero records, because January is outside the range. + - Setting the "Range" filter in February, while setting month of March in "Date and Time" filter. The result is no records, because March is outside the Range. + ## v3.0.34 - CE-1101 A search bar is updated for projects across Arbimon diff --git a/app/model/recordings.js b/app/model/recordings.js index 053ef4b96..a1e1e8003 100644 --- a/app/model/recordings.js +++ b/app/model/recordings.js @@ -1159,8 +1159,7 @@ var Recordings = { constraints.push('YEAR(r.datetime) IN (?)'); data.push(parameters.years); } - - if(parameters.months) { + if(parameters.months !== undefined) { constraints.push('MONTH(r.datetime) IN (?)'); data.push((parameters.months instanceof Array) ? parameters.months.map(function(m) { return parseInt(m)+1; }) :