Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picking error for 0742fdc35072d21f572474d9917cb72d1594ede3 #1386

Open
github-actions bot opened this issue Feb 26, 2025 · 0 comments
Open

Cherry-picking error for 0742fdc35072d21f572474d9917cb72d1594ede3 #1386

github-actions bot opened this issue Feb 26, 2025 · 0 comments
Assignees

Comments

@github-actions
Copy link
Contributor

gitstream tried to cherry-pick commit 0742fdc35072d21f572474d9917cb72d1594ede3 from https://github.com/kubernetes-sigs/kernel-module-management but was unable to do so.

Commit message:

Changing MSBC image status structure

Currently MBSC image's spec contains the action that MBSC controller
should execute(sign or build). But since the action does not exists in
the image's status, the MIC controller cannot know if the success status
refers to the previous action (i.e build) or the current requested
action( i.e sign). In addition, since action will appear in status,
there is no need to have explicit statuses like BuildFailed: we change
it to ActionFailed or ActionSuccess.
This PR contains the following:
1) adding action field to the MBSC image' status
2) chaning the type of Status field: now it will be only ActionFailure
   or ActionSuccess
2) update the MIC controller MBSC lookup function to decide what is the
   current status of image in MIC, based on MBSC image's action and
status fields
3) unit-tests

Please cherry-pick the commit manually.


Error:

could not cherry-pick: could not run a command 0 before committing: exit status 1

Upstream-Commit: 0742fdc35072d21f572474d9917cb72d1594ede3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant