From 3103f20653e3d71ed1e25dbfa60cd7148c92af63 Mon Sep 17 00:00:00 2001 From: Katerina Koukiou Date: Mon, 24 Feb 2025 14:41:00 +0100 Subject: [PATCH] dracut: add static linkage to internal functions Added the `static` keyword to functions that are not used outside their respective source files to limit their linkage and prevent potential symbol conflicts. --- dracut/dd/dd_extract.c | 2 +- dracut/dd/dd_list.c | 6 +++--- dracut/dd/rpmutils.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dracut/dd/dd_extract.c b/dracut/dd/dd_extract.c index 6542df1b137..e833107c065 100644 --- a/dracut/dd/dd_extract.c +++ b/dracut/dd/dd_extract.c @@ -80,7 +80,7 @@ void show_help() { * during cpio extraction, only extract files we need * eg. module .ko files and firmware directory */ -int dlabelFilter(const char* name, const struct stat *fstat, int packageflags, void *userptr) +static int dlabelFilter(const char* name, const struct stat *fstat, int packageflags, void *userptr) { int l = strlen(name); diff --git a/dracut/dd/dd_list.c b/dracut/dd/dd_list.c index dd33b10c5ca..0d39babd0e7 100644 --- a/dracut/dd/dd_list.c +++ b/dracut/dd/dd_list.c @@ -58,7 +58,7 @@ struct _version_struct { char* anaconda; }; -int globErrFunc(const char *epath, int eerrno) +static int globErrFunc(const char *epath, int eerrno) { /* TODO check fatal errors */ @@ -86,7 +86,7 @@ void show_help() { * we use it to check if kernel-modules = * and installer-enhancement = */ -int dlabelProvides(const char* dep, const char* version, uint32_t sense, void *userptr) +static int dlabelProvides(const char* dep, const char* version, uint32_t sense, void *userptr) { char *kernelver = ((struct _version_struct*)userptr)->kernel; char *anacondaver = ((struct _version_struct*)userptr)->anaconda; @@ -132,7 +132,7 @@ int dlabelProvides(const char* dep, const char* version, uint32_t sense, void *u /** * Print information about the rpm to stdout */ -int dlabelOK(const char* source, Header *h, int packageflags) +static int dlabelOK(const char* source, Header *h, int packageflags) { struct rpmtd_s tdname; struct rpmtd_s tddesc; diff --git a/dracut/dd/rpmutils.c b/dracut/dd/rpmutils.c index 72a5cb2fd4e..cc60c4e4224 100644 --- a/dracut/dd/rpmutils.c +++ b/dracut/dd/rpmutils.c @@ -54,14 +54,14 @@ struct cpio_mydata { * libarchive callbacks */ -ssize_t rpm_myread(struct archive *a, void *client_data, const void **buff) +static ssize_t rpm_myread(struct archive *a, void *client_data, const void **buff) { struct cpio_mydata *mydata = client_data; *buff = mydata->buffer; return Fread(mydata->buffer, 1, BUFFERSIZE, mydata->gzdi); } -int rpm_myclose(struct archive *a, void *client_data) +static int rpm_myclose(struct archive *a, void *client_data) { struct cpio_mydata *mydata = client_data; if (mydata->gzdi > 0) @@ -81,7 +81,7 @@ int init_rpm() { /* read data from RPM header */ -const char * headerGetString(Header h, rpmTagVal tag) +static const char * headerGetString(Header h, rpmTagVal tag) { const char *res = NULL; struct rpmtd_s td;