Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer doesn't bootstrap config or path #6

Open
lachlan2k opened this issue Nov 12, 2022 · 1 comment
Open

Installer doesn't bootstrap config or path #6

lachlan2k opened this issue Nov 12, 2022 · 1 comment

Comments

@lachlan2k
Copy link
Contributor

Issue or Bug

Description

The install.sh script doesn't ensure ~/.local/bin is in the users path, and doesn't create a config file by default.

When you first try to run the riptide client cli after installing, you may have the following experience. First, it can't find the program, then, when you specify the path to it, it indefnitely hangs:

image

I personally didn't have ~/.local/bin in my path on my dev vm, so I presumed the installer failed.

A quick strace reveals the program hangs because the config file doesn't exist:
image

Tasks/General Thoughts

  • Ensure a default config file is installed by install.sh.
  • If a config file isn't present, give a helpful error message instead of locking up.
  • The install script should detect if ~/.local/bin is in the users path. If it isn't, it should at the very least warn the user. It should also say "Hey you might wanna add export PATH="$PATH:~/.local/bin" to your shell RC" or whatever. Ideally, it should even offer a y/n prompt to do this.
    • Modifying the user's shell config without asking is a bit invasive, so I wouldn't advise this.
@lachlan2k
Copy link
Contributor Author

Just realized the config issue is probably already patched in main but not the latest release. I'll build the cli myself and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant