insts_base: ignore architecture in SFENCE_VMA

[radimkrcmar]

Another patch from the mstatus cleanup, #683 (comment).

[github-actions]

Test Results

392 tests  ±0   392 ✅ ±0   1m 21s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 825a625. ± Comparison against base commit 8ca0ac0.

[jordancarlin]

LGTM

[Timmmm]

LGTM. Any idea why it was there in the first place?

[jordancarlin]

Any idea why it was there in the first place?

Looks like a remnant from this version from 7 years ago:

function clause execute SFENCE_VMA(rs1, rs2) = {
  /* TODO: handle PMP/TLB synchronization when executed in M-mode. */
  if   cur_privilege == User
  then { handle_illegal(); false }
  else match (architecture(mstatus.SXL()), mstatus.TVM()) {
    (Some(RV64), true)  => { handle_illegal(); false },
    (Some(RV64), false) => {
      let addr : option(vaddr39) = if rs1 == 0 then None() else Some(X(rs1)[38 .. 0]);
      let asid : option(asid64)  = if rs2 == 0 then None() else Some(X(rs2)[15 .. 0]);
      flushTLB(asid, addr);
      true
    },
    (_, _) => internal_error("unimplemented sfence architecture")
  }
}

Seemingly it only supported RV64 at the time.