Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lean: improve handwritten support #754

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

ineol
Copy link
Contributor

@ineol ineol commented Feb 24, 2025

No description provided.

Copy link

github-actions bot commented Feb 24, 2025

Test Results

392 tests  ±0   392 ✅ ±0   1m 18s ⏱️ -3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit ba5a0b1. ± Comparison against base commit 8387b14.

♻️ This comment has been updated with latest results.

@ineol ineol force-pushed the lean-handwritten-2 branch 2 times, most recently from 777a25d to 7f7ee95 Compare February 26, 2025 15:31
@ineol ineol marked this pull request as ready for review February 26, 2025 15:35
@Timmmm
Copy link
Collaborator

Timmmm commented Feb 26, 2025

Can you add a description? I'll take your word for it on the actual code (still learning Lean).

Adds a few miscellaneous definitions needed by the Sail model in the
Lean support file, and sets up a measure for the type of extensions so
that Lean can prove termination of `extensionEnabled`.
@ineol ineol force-pushed the lean-handwritten-2 branch from 92f5bf0 to ba5a0b1 Compare February 27, 2025 10:27
@ineol
Copy link
Contributor Author

ineol commented Feb 27, 2025

I added a description to the commit. Is that enough or should I also add it to the PR?

@Timmmm
Copy link
Collaborator

Timmmm commented Feb 27, 2025

Yep that's fine.

@Timmmm Timmmm merged commit 32587ca into riscv:master Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants