Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider making WidgetDetails member values private #72

Closed
rmpowell77 opened this issue Feb 1, 2023 · 2 comments
Closed

consider making WidgetDetails member values private #72

rmpowell77 opened this issue Feb 1, 2023 · 2 comments
Milestone

Comments

@rmpowell77
Copy link
Owner

Currently:

template <typename ConcreteWidget, typename Underlying>
struct WidgetDetails {
...
public:
    std::optional<wxSizerFlags> flags;
    // these are common across the controls
    wxWindowID identity = wxID_ANY;
    wxPoint pos = wxDefaultPosition;
    wxSize size = wxDefaultSize;
    int64_t usingStyle {};
    Underlying** windowHandle {};
};

Consider making these private.

@rmpowell77 rmpowell77 added this to the v0.1.2 milestone Feb 1, 2023
rmpowell77 added a commit that referenced this issue Feb 1, 2023
Issue #72: consider making WidgetDetails member values private
@rmpowell77
Copy link
Owner Author

Fixed in #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant