Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elm-deps as dependencies #5

Open
robinheghan opened this issue Sep 3, 2018 · 7 comments
Open

Add elm-deps as dependencies #5

robinheghan opened this issue Sep 3, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@robinheghan
Copy link
Owner

robinheghan commented Sep 3, 2018

Git deps might have direct and indirect dependencies which aren't git-dependencies. These should be added to the right places in the application's elm.json.

Not entirely sure how this should work. Do we clone the repos and read their tags, scrape package.elm-lang.org? Needs investigating.

@robinheghan robinheghan added this to the 1.0.0 milestone Sep 3, 2018
@robinheghan robinheghan self-assigned this Sep 3, 2018
@robinheghan robinheghan added the enhancement New feature or request label Sep 4, 2018
@robinheghan robinheghan changed the title Add elm-deps as indirect dependencies Add elm-deps as dependencies Sep 5, 2018
@robinheghan robinheghan added the question Further information is requested label Sep 10, 2018
@MartinSStewart
Copy link

I ran into an issue where I installed a git-dependency but my app failed to compile due to missing all the dependencies for that package. At first I thought this was a bug but if I understand correctly that's what this issue is referring too?

@robinheghan
Copy link
Owner Author

@MartinSStewart Yes. Not sure how to best approach this issue. I don't think elm install supports specifying a version range, if it did it would be a simple matter of iterating through all dependencies in elm.json and calling elm install on them 🤷‍♂️

@MartinSStewart
Copy link

What about using elm-json instead?

@robinheghan
Copy link
Owner Author

That could work. I do have limited capacity at the moment however. A PR would be much appreciated if you have the time.

@MartinSStewart
Copy link

I can take a look later today and see if it's something I can puzzle out.

@robinheghan
Copy link
Owner Author

Awesome!

@MartinSStewart
Copy link

Sorry, I won't have time to do this either. Maybe someone else can implement this or maybe I'll give it a shot at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants