Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IJointCoupling::evaluateCoupledJointsJacobian() #3177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PasMarra
Copy link

This PR introduces IJointCoupling::evaluateCoupledJointsJacobian(), whose implementation should calculates the Jacobian mapping the Actuated Axes to Physical Joints velocity

@PasMarra PasMarra requested a review from randaz81 as a code owner February 12, 2025 16:47
Copy link

update-docs bot commented Feb 12, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2025

CLA assistant check
All committers have signed the CLA.

@traversaro
Copy link
Member

Thanks for the contribution. Could it make sense to:

  • Document mathematically what this function returns? You can take an inspiration from the existing documentation on how to do that, from what understand we already define the same quantity in the other methods.
  • Use a name more compatible with existing nomenclature, so something like evaluateJacobianFromActuatedAxesToPhysicalJointsVel ? In this way we can be ready if necessary to introduce other methods in the future (for example evaluateJacobianFromPhysicalJointsToActuatedAxeseVel).

@Nicogene
Copy link
Member

Use a name more compatible with existing nomenclature, so something like evaluateJacobianFromActuatedAxesToPhysicalJointsVel ? In this way we can be ready if necessary to introduce other methods in the future (for example evaluateJacobianFromPhysicalJointsToActuatedAxeseVel).

I was wondering if it makes sense to already add evaluateJacobianFromPhysicalJointsToActuatedAxeseVel

@randaz81
Copy link
Member

I think these methods should be moved to a new interface:
IJacobianXXX as virtual abstract.

  • implementJointCoupling file will then not need any modification.

  • The device that will have these capabilities will inherit from IJacobianXXX

  • The user code will attempt to view the new interface. If not implemented the ->view() method will return false, allowing the user to detect if the device implements the interface or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants