Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chain, onThen, onCatch, onFinally should handle non-promise promise #27

Open
TwitchBronBron opened this issue Feb 27, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@TwitchBronBron
Copy link
Member

If you pass a non promise to promises.chain(), .onThen(), onCatch, onFinally(), it should convert any non-promises to promises rather than forcing the outside to promisify them. The developer's intent is to take that value and wait for it and run something in the callback, so it being a non-promise doesn't really matter.

This isn't a breaking change because previously it would throw an exception

@TwitchBronBron TwitchBronBron added the bug Something isn't working label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant