Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to alter isident inside of Dlist [Enhancement request] #4

Open
fourjay opened this issue Feb 16, 2017 · 4 comments
Open

Ability to alter isident inside of Dlist [Enhancement request] #4

fourjay opened this issue Feb 16, 2017 · 4 comments
Assignees

Comments

@fourjay
Copy link

fourjay commented Feb 16, 2017

Please consider adding the ability to set a local (preferably per buffer) ability to set isident inside of the Dlist command.
Reason looks like vim's dlist is not very workable outside of C, in that isident is overloaded elsewhere. I was trying to get dlist working inside of viml (as a first step to extending to other languages) and found the help warning

Careful: If you change this option, it might break expanding environment variables.

A little experimentation and I see altering isident does help vim find definitions, but it also breaks other things. Which makes ability to adjust this temporarily inside the Dlist command potentially useful.

@fourjay
Copy link
Author

fourjay commented Feb 16, 2017

FWIW, I've got a sort of workaround in place. In my scenario, without isident, the generic search breaks. So I have a wrapper function with an empty search and then, from your vim-qf plugin, using Keep to limit the search.

@fourjay fourjay closed this as completed Feb 16, 2017
@fourjay fourjay reopened this Feb 16, 2017
@romainl
Copy link
Owner

romainl commented Feb 17, 2017

Hi! Would a static list of adequate per-filetype isident be an adequate solution?

@fourjay
Copy link
Author

fourjay commented Feb 17, 2017

I think so.
From a cursory look at the vim-use list conversation I suspect Bran knows that this is an issue, but it's on a way back burner. It looks like all the definition|method jumping was long ago hard-coded with C in mind and it's hard to undo (include, define etc. all are more less made for C)
Since your plugin more or less completely wraps dlist and cousins [d it's a good place to put a workaround for isidentweaknesses. Thanks for the plugin. I've just discovered vimsincludecorner and am addingdefinesandincludes`` to several odd languages I work with (it's quite nice to add to ansible for example).

@romainl
Copy link
Owner

romainl commented Feb 17, 2017

I will take a look at this over the week-end.

@romainl romainl self-assigned this Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants