Skip to content

Commit

Permalink
Issue checkstyle#15218: Formatted input file of section 6.2 Caught Ex…
Browse files Browse the repository at this point in the history
…ceptions: not ignored to follow google style guide rules
  • Loading branch information
Zopsss authored and romani committed Jul 13, 2024
1 parent 149341f commit 6d8f8f2
Showing 1 changed file with 81 additions and 63 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,90 +2,108 @@
// Test case file for checkstyle.
// Created: 2001
///////////////////////////////////////////////////////////////////////////////////////////////
package com.google.checkstyle.test.chapter6programpractice.rule62donotignoreexceptions;

import java.io.*;
import java.awt.Dimension;
import java.awt.Color;
package com.google.checkstyle.test.chapter6programpractice.rule62donotignoreexceptions;

class InputEmptyFinallyBlock {
boolean flag;

void doSm() {}

void foo() {
try {
if (!flag) {
doSm();
}
} catch (Exception e) {
/* ignore */
} finally { // ok
/* ignore */
} // ok
}

void foo2() {
try {
if (!flag) {
doSm();
}
} catch (Exception e) {
} finally {
} // violation above 'Empty finally block.'
}

class Inner {
boolean flag;

void doSm() {}

void foo() {
try {
if (!flag) {
doSm();
}
} catch (Exception e) { /* ignore */ } //ok
finally {/* ignore */} //ok
try {
if (!flag) {
doSm();
}
} catch (Exception e) {
/* ignore */
} finally { // ok
/* ignore */
} // ok
}

void foo2() {
try {
if (!flag) {
doSm();
}
} catch (Exception e) {}
finally {} // violation 'Empty finally block.'
}

class Inner {
boolean flag;
void doSm() {}
void foo() {
try {
if (!flag) {
doSm();
}
} catch (Exception e) { /* ignore */ } //ok
finally {/* ignore */} //ok
}

void foo2() {
try {
if (!flag) {
doSm();
}
} catch (Exception e) {}
finally {} // violation 'Empty finally block.'
try {
if (!flag) {
doSm();
}
} catch (Exception e) {
} finally {
} // violation above 'Empty finally block.'
}
}

Inner anon = new Inner(){
Inner anon =
new Inner() {
boolean flag;

void doSm() {}

void foo() {
try {
if (!flag) {
doSm();
}
} catch (Exception e) { /* ignore */ } //ok
finally {/* ignore */} //ok
try {
if (!flag) {
doSm();
}
} catch (Exception e) {
/* ignore */
} finally { // ok
/* ignore */
} // ok
}

void foo2() {
try {
if (!flag) {
doSm();
}
} catch (Exception e) {}
finally {} // violation 'Empty finally block.'
try {
if (!flag) {
doSm();
}
} catch (Exception e) {
} finally {
} // violation above 'Empty finally block.'
}
};
};

void bar1() {
try {
if(!flag) {
doSm();
}
} catch (Exception expected) {}
void bar1() {
try {
if (!flag) {
doSm();
}
} catch (Exception expected) {
}
}

void bar2() {
try {
if(!flag) {
doSm();
}
} catch (Exception expected) {}
void bar2() {
try {
if (!flag) {
doSm();
}
} catch (Exception expected) {
}
}
}

0 comments on commit 6d8f8f2

Please sign in to comment.