Issue checkstyle#13999: Resolve pitest suppression for parseTag() met…

…hod of TagParser
romani · Dec 29, 2023 · aa68921 · aa68921
1 parent 16afdef
commit aa68921
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 17 deletions.
diff --git a/config/pitest-suppressions/pitest-javadoc-suppressions.xml b/config/pitest-suppressions/pitest-javadoc-suppressions.xml
@@ -324,15 +324,6 @@
     <lineContent>text = text.substring(column).trim();</lineContent>
   </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>TagParser.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.TagParser</mutatedClass>
-    <mutatedMethod>parseTag</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
-    <description>removed conditional - replaced equality check with false</description>
-    <lineContent>if (incompleteTag) {</lineContent>
-  </mutation>
-
   <mutation unstable="false">
     <sourceFile>TagParser.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.TagParser</mutatedClass>

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/TagParser.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/TagParser.java
@@ -127,14 +127,7 @@ private Point parseTag(String[] text, int lineNo, final int nLines, Point positi
         final Point endTag = findChar(text, '>', position);
         final boolean incompleteTag = endTag.getLineNo() >= nLines;
         // get tag id (one word)
-        final String tagId;
-
-        if (incompleteTag) {
-            tagId = "";
-        }
-        else {
-            tagId = getTagId(text, position);
-        }
+        final String tagId = getTagId(text, position);
         // is this closed tag
         final boolean closedTag =
                 endTag.getLineNo() < nLines