From aa6892154233c51382bd3ad3461d954aa899767d Mon Sep 17 00:00:00 2001 From: Suniti Date: Wed, 27 Dec 2023 10:14:43 +0530 Subject: [PATCH] Issue #13999: Resolve pitest suppression for parseTag() method of TagParser --- .../pitest-suppressions/pitest-javadoc-suppressions.xml | 9 --------- .../tools/checkstyle/checks/javadoc/TagParser.java | 9 +-------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/config/pitest-suppressions/pitest-javadoc-suppressions.xml b/config/pitest-suppressions/pitest-javadoc-suppressions.xml index ab3043327f7..8dbebf1483e 100644 --- a/config/pitest-suppressions/pitest-javadoc-suppressions.xml +++ b/config/pitest-suppressions/pitest-javadoc-suppressions.xml @@ -324,15 +324,6 @@ text = text.substring(column).trim(); - - TagParser.java - com.puppycrawl.tools.checkstyle.checks.javadoc.TagParser - parseTag - org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE - removed conditional - replaced equality check with false - if (incompleteTag) { - - TagParser.java com.puppycrawl.tools.checkstyle.checks.javadoc.TagParser diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/TagParser.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/TagParser.java index 0d08325224f..048b44f0195 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/TagParser.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/TagParser.java @@ -127,14 +127,7 @@ private Point parseTag(String[] text, int lineNo, final int nLines, Point positi final Point endTag = findChar(text, '>', position); final boolean incompleteTag = endTag.getLineNo() >= nLines; // get tag id (one word) - final String tagId; - - if (incompleteTag) { - tagId = ""; - } - else { - tagId = getTagId(text, position); - } + final String tagId = getTagId(text, position); // is this closed tag final boolean closedTag = endTag.getLineNo() < nLines