Issue checkstyle#14814: refactor containsStaticField into iterative m…

…ethod
romani · Nov 3, 2024 · d7c12da · d7c12da
1 parent 168b63d
commit d7c12da
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheck.java
@@ -670,13 +670,15 @@ public boolean containsInstanceField(String field) {
          *
          * @param field the field to check
          * @return true if this FieldFrame contains static field
-         * @noinspection TailRecursion
-         * @noinspectionreason TailRecursion - until issue #14814
          */
         public boolean containsStaticField(String field) {
-            return staticFields.contains(field)
-                    || parent != null
-                    && parent.containsStaticField(field);
+            FieldFrame currentParent = parent;
+            boolean contains = staticFields.contains(field);
+            while (currentParent != null && !contains) {
+                contains = currentParent.staticFields.contains(field);
+                currentParent = currentParent.parent;
+            }
+            return contains;
         }
 
         /**