Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nostr address format #2209

Closed
2 of 3 tasks
jolestar opened this issue Jul 17, 2024 · 7 comments
Closed
2 of 3 tasks

Support nostr address format #2209

jolestar opened this issue Jul 17, 2024 · 7 comments
Labels
area::bitcoin area::example Examples
Milestone
Rooch v0.7

Comments

@jolestar
Copy link
Contributor

jolestar commented Jul 17, 2024 •
edited
Loading

After #1770, all Bitcoin addresses can generate a rooch address. The nostr address is the same as the bitcoin taproot address type bip340 nips01

relative issue #406 #451
@jolestar jolestar added this to the Rooch v0.7 milestone Jul 17, 2024
@jolestar jolestar added this to Rooch Jul 17, 2024
@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator

I think I can look the first issue #2211.

@jolestar
Copy link
Contributor Author

@feliciss, Can you continue the second issue? It just updates the RoochOrBitcoinAddress::from_str, for supports parsing nostr bech32 address -> Bitcoin Address -> RoochAddress.

@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator

@feliciss, Can you continue the second issue? It just updates the RoochOrBitcoinAddress::from_str, for supports parsing nostr bech32 address -> Bitcoin Address -> RoochAddress.

Okay.

Merged
@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator

Submitted a new PR #2235.

@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator

Is the third task related to TypeScript?

@jolestar
Copy link
Contributor Author

Is the third task related to TypeScript?

yes

@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4
Copy link
Collaborator

Is the third task related to TypeScript?

yes

I think it might be handled by @wow-sven ?

@jolestar jolestar mentioned this issue Aug 19, 2024
Closed
@github-project-automation github-project-automation bot moved this to Done in Rooch Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area::bitcoin area::example Examples
Projects
Rooch
Status: Done
Milestone
Rooch v0.7
Development

No branches or pull requests
2 participants
@jolestar @ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4