From 1d8e09decd378b857b639104e43234dc7b7c04a5 Mon Sep 17 00:00:00 2001 From: Rosano Coutinho Date: Sat, 2 Mar 2024 15:51:49 -0500 Subject: [PATCH] spec debug item --- os-app/open-guide/text-en.md | 1 + os-app/open-play/main.svelte | 12 ++++++++++++ os-app/sub-detail/i18n-en.yml | 1 + os-app/sub-detail/i18n-es.yml | 1 + os-app/sub-detail/i18n-fr.yml | 1 + os-app/sub-detail/i18n-pt.yml | 1 + os-app/sub-detail/main.svelte | 9 ++++++++- os-app/sub-detail/rollup-start.js | 3 +++ os-app/sub-detail/stub-view.ejs | 5 +++++ os-app/sub-detail/ui-test-_access.js | 4 ++++ os-app/sub-detail/ui-test-_localize.js | 4 ++++ os-app/sub-detail/ui-test-_misc.js | 22 ++++++++++++++++++++++ 12 files changed, 63 insertions(+), 1 deletion(-) diff --git a/os-app/open-guide/text-en.md b/os-app/open-guide/text-en.md index ce964d5..80377f3 100644 --- a/os-app/open-guide/text-en.md +++ b/os-app/open-guide/text-en.md @@ -99,6 +99,7 @@ Note: this only works with a trailing slash before `#`. | Submit capture box | `Control+Enter` or `Command+Enter` | | `JBXPlayDetailToolbarArchiveButtonText` | Launcher | | `JBXPlayDetailToolbarUnarchiveButtonText` | Launcher | +| `JBXPlayDetailToolbarDebugButtonText` | Launcher | | Select previous or next item, if filter field is focused | `Up` or `Down` | | Clear filter text and selected item, focus filter field | `Escape` | | Close, if filter field is focused | `Escape` | diff --git a/os-app/open-play/main.svelte b/os-app/open-play/main.svelte index d8ca0ed..339c316 100644 --- a/os-app/open-play/main.svelte +++ b/os-app/open-play/main.svelte @@ -493,6 +493,17 @@ const mod = { mod.ControlDocumentDiscard(mod._OLSKCatalog.modPublic.OLSKCatalogDataItemSelected()); }, + JBXPlayDetailDispatchDebug () { + const url = `https://inspektor.5apps.com/inspect?path=joybox%2F${ encodeURIComponent(JBXDocument.JBXDocumentObjectPath(mod._OLSKCatalog.modPublic.OLSKCatalogDataItemSelected())) }`; + + if (OLSK_SPEC_UI()) { + window.FakeWindowOpen = url; + return; + } + + window.open(url) + }, + JBXPlayDetailDispatchQueue () { mod.ControlDocumentQueue(mod._OLSKCatalog.modPublic.OLSKCatalogDataItemSelected()); }, @@ -847,6 +858,7 @@ import OLSKUIAssets from 'OLSKUIAssets'; JBXPlayDetailDispatchFetch={ mod.JBXPlayDetailDispatchFetch } JBXPlayDetailDispatchUpdate={ mod.JBXPlayDetailDispatchUpdate } JBXPlayDetailDispatchDiscard={ mod.JBXPlayDetailDispatchDiscard } + JBXPlayDetailDispatchDebug={ mod.JBXPlayDetailDispatchDebug } JBXPlayDetailDispatchQueue={ mod.JBXPlayDetailDispatchQueue } bind:this={ mod._JBXPlayDetail } /> diff --git a/os-app/sub-detail/i18n-en.yml b/os-app/sub-detail/i18n-en.yml index 40b1c03..8ac7161 100644 --- a/os-app/sub-detail/i18n-en.yml +++ b/os-app/sub-detail/i18n-en.yml @@ -3,6 +3,7 @@ JBXPlayDetailToolbarQueueButtonText: Add to collection JBXPlayDetailToolbarArchiveButtonText: Archive JBXPlayDetailToolbarUnarchiveButtonText: Unarchive JBXPlayDetailToolbarDiscardButtonText: Discard +JBXPlayDetailToolbarDebugButtonText: Debug JBXPlayDetailMediaURLFieldText: URL JBXPlayDetailMediaOpenButtonText: Open JBXPlayDetailMediaFetchButtonText: Fetch diff --git a/os-app/sub-detail/i18n-es.yml b/os-app/sub-detail/i18n-es.yml index d7bfdbb..cf2360e 100644 --- a/os-app/sub-detail/i18n-es.yml +++ b/os-app/sub-detail/i18n-es.yml @@ -3,6 +3,7 @@ JBXPlayDetailToolbarQueueButtonText: Añadir a la colección JBXPlayDetailToolbarArchiveButtonText: Archivar JBXPlayDetailToolbarUnarchiveButtonText: Desarchivar JBXPlayDetailToolbarDiscardButtonText: Descartar +JBXPlayDetailToolbarDebugButtonText: Debug JBXPlayDetailMediaURLFieldText: URL JBXPlayDetailMediaOpenButtonText: Abrir JBXPlayDetailMediaFetchButtonText: Recuperar diff --git a/os-app/sub-detail/i18n-fr.yml b/os-app/sub-detail/i18n-fr.yml index 305834b..3895f6f 100644 --- a/os-app/sub-detail/i18n-fr.yml +++ b/os-app/sub-detail/i18n-fr.yml @@ -3,6 +3,7 @@ JBXPlayDetailToolbarQueueButtonText: Ajouter à la collection JBXPlayDetailToolbarArchiveButtonText: Archiver JBXPlayDetailToolbarUnarchiveButtonText: Désarchiver JBXPlayDetailToolbarDiscardButtonText: Jeter +JBXPlayDetailToolbarDebugButtonText: Debug JBXPlayDetailMediaURLFieldText: URL JBXPlayDetailMediaOpenButtonText: Ouvrir JBXPlayDetailMediaFetchButtonText: Chercher diff --git a/os-app/sub-detail/i18n-pt.yml b/os-app/sub-detail/i18n-pt.yml index 3056002..c710404 100644 --- a/os-app/sub-detail/i18n-pt.yml +++ b/os-app/sub-detail/i18n-pt.yml @@ -3,6 +3,7 @@ JBXPlayDetailToolbarQueueButtonText: Adicionar à coleção JBXPlayDetailToolbarArchiveButtonText: Arquivar JBXPlayDetailToolbarUnarchiveButtonText: Desarquivar JBXPlayDetailToolbarDiscardButtonText: Descartar +JBXPlayDetailToolbarDebugButtonText: Debug JBXPlayDetailMediaURLFieldText: URL JBXPlayDetailMediaOpenButtonText: Abrir JBXPlayDetailMediaFetchButtonText: Buscar diff --git a/os-app/sub-detail/main.svelte b/os-app/sub-detail/main.svelte index 1c53e49..db470ea 100644 --- a/os-app/sub-detail/main.svelte +++ b/os-app/sub-detail/main.svelte @@ -2,6 +2,7 @@ export let JBXPlayDetailItem; export let JBXPlayDetailDispatchBack; export let JBXPlayDetailDispatchArchive; +export let JBXPlayDetailDispatchDebug; export let JBXPlayDetailDispatchUnarchive; export let JBXPlayDetailDispatchFetch; export let JBXPlayDetailDispatchUpdate; @@ -28,7 +29,13 @@ const mod = { // DATA DataPlayDetailRecipes () { - const outputData = []; + const outputData = [{ + LCHRecipeSignature: 'JBXPlayDetailLauncherItemDebug', + LCHRecipeName: OLSKLocalized('JBXPlayDetailToolbarDebugButtonText'), + LCHRecipeCallback: function JBXPlayDetailLauncherItemDebug () { + JBXPlayDetailDispatchDebug() + }, + }]; if (!JBXPlayDetailItem.$JBXDocumentIsInbox && !JBXPlayDetailItem.JBXDocumentArchiveDate) { outputData.push({ diff --git a/os-app/sub-detail/rollup-start.js b/os-app/sub-detail/rollup-start.js index 4fe4fdc..6d79221 100644 --- a/os-app/sub-detail/rollup-start.js +++ b/os-app/sub-detail/rollup-start.js @@ -23,6 +23,9 @@ const JBXPlayDetail = new RollupStart({ JBXPlayDetailDispatchDiscard: (function () { window.TestJBXPlayDetailDispatchDiscard.innerHTML = parseInt(window.TestJBXPlayDetailDispatchDiscard.innerHTML) + 1; }), + JBXPlayDetailDispatchDebug: (function () { + window.TestJBXPlayDetailDispatchDebug.innerHTML = parseInt(window.TestJBXPlayDetailDispatchDebug.innerHTML) + 1; + }), JBXPlayDetailDispatchQueue: (function () { window.TestJBXPlayDetailDispatchQueue.innerHTML = parseInt(window.TestJBXPlayDetailDispatchQueue.innerHTML) + 1; }), diff --git a/os-app/sub-detail/stub-view.ejs b/os-app/sub-detail/stub-view.ejs index 2a1f717..d98d4af 100644 --- a/os-app/sub-detail/stub-view.ejs +++ b/os-app/sub-detail/stub-view.ejs @@ -43,6 +43,11 @@ locals.OLSKPagePublicConstants = { 0

+

+ JBXPlayDetailDispatchDebug + 0 +

+

JBXPlayDetailDispatchQueue 0 diff --git a/os-app/sub-detail/ui-test-_access.js b/os-app/sub-detail/ui-test-_access.js index d0e53f9..2e2b1ff 100644 --- a/os-app/sub-detail/ui-test-_access.js +++ b/os-app/sub-detail/ui-test-_access.js @@ -108,6 +108,10 @@ describe('JBXPlayDetail_Access', function () { return browser.assert.OLSKLauncherItems('JBXPlayDetailLauncherItemUnarchive', 0); }); + it('shows JBXPlayDetailLauncherItemDebug', function () { + return browser.assert.OLSKLauncherItems('JBXPlayDetailLauncherItemDebug', 1); + }); + context('JBXDocumentURL', function() { before(function() { diff --git a/os-app/sub-detail/ui-test-_localize.js b/os-app/sub-detail/ui-test-_localize.js index c372290..ddae32b 100644 --- a/os-app/sub-detail/ui-test-_localize.js +++ b/os-app/sub-detail/ui-test-_localize.js @@ -55,6 +55,10 @@ kDefaultRoute.OLSKRouteLanguageCodes.forEach(function (OLSKRoutingLanguage) { return browser.assert.OLSKLauncherItemText('JBXPlayDetailLauncherItemArchive', uLocalized('JBXPlayDetailToolbarArchiveButtonText')); }); + it('localizes JBXPlayDetailLauncherItemDebug', function () { + return browser.assert.OLSKLauncherItemText('JBXPlayDetailLauncherItemDebug', uLocalized('JBXPlayDetailToolbarDebugButtonText')); + }); + context('discard', function () { it('localizes JBXPlayDetailDiscardConfirm', function() { diff --git a/os-app/sub-detail/ui-test-_misc.js b/os-app/sub-detail/ui-test-_misc.js index 1fe5d8c..3e99ec4 100644 --- a/os-app/sub-detail/ui-test-_misc.js +++ b/os-app/sub-detail/ui-test-_misc.js @@ -467,6 +467,28 @@ describe('JBXPlayDetail_Misc', function () { }); + describe('JBXPlayDetailLauncherItemDebug', function test_JBXPlayDetailLauncherItemDebug() { + + before(function() { + return browser.OLSKVisit(kDefaultRoute, { + JBXPlayDetailItem: JSON.stringify(StubDocumentObjectValid()), + }); + }); + + before(function () { + browser.assert.text('#TestJBXPlayDetailDispatchDebug', '0'); + }); + + before(function () { + return browser.OLSKLauncherRun('JBXPlayDetailLauncherItemDebug'); + }); + + it('sends JBXPlayDetailDispatchDebug', function () { + browser.assert.text('#TestJBXPlayDetailDispatchDebug', '1'); + }); + + }); + context('$JBXDocumentIsInbox', function() { before(function() {