Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the function names in contract "provider" layer are not intuitive #281

Open
ska1296 opened this issue Aug 24, 2023 · 0 comments
Open

the function names in contract "provider" layer are not intuitive #281

ska1296 opened this issue Aug 24, 2023 · 0 comments

Comments

@ska1296
Copy link
Contributor

ska1296 commented Aug 24, 2023

The contract "provider" layer interacts with the ABI and returns a value or calldata. It never writes to the chain. But this layer has functions like "execute" and "handleOps", which are counterintuitive if you don't have context of the layering.
Renaming these functions to add a prefix or suffix or adding ".call()" properties can make the code a bit more readable.

@ska1296 ska1296 mentioned this issue Aug 24, 2023
11 tasks
@ska1296 ska1296 linked a pull request Aug 24, 2023 that will close this issue
@ska1296 ska1296 removed a link to a pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant