Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error early when trying to deploy a model from a temporary board #250

Open
juliasilge opened this issue Oct 3, 2023 · 1 comment
Open
Labels
feature a feature request or enhancement

Comments

@juliasilge
Copy link
Member

Related to rstudio/vetiver-python#193

When calling vetiver_deploy_rsconnect() or the functions for Docker, we should check that the board isn't a board_temp() and error early if it is.

The SageMaker functions already check that the board uses S3:

vetiver-r/R/sagemaker.R

Lines 66 to 68 in 5d3fd53

if (!inherits(board, "pins_board_s3")) {
stop_input_type(board, "an S3 pins board")
}

@juliasilge juliasilge changed the title Error early when trying to deploy a temporary board Error early when trying to deploy a model from a temporary board Oct 3, 2023
@juliasilge
Copy link
Member Author

Oh, slight hiccup here! Our board_temp() doesn't have a separate class from a board_folder():

library(pins)
class(board_temp())
#> [1] "pins_board_folder" "pins_board"

Created on 2023-10-11 with reprex v2.0.2

@juliasilge juliasilge added the feature a feature request or enhancement label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant