Skip to content

Commit d0119a3

Browse files
authored
Merge pull request #46 from rubberduck-vba/webhook
Fix webhook auth: use HMACSHA256
2 parents ce66d3f + 2029976 commit d0119a3

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

rubberduckvba.Server/WebhookSignatureValidationService.cs

+5-3
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,13 @@ private bool IsValidSignature(string? signature, string payload)
6161
{
6262
return false;
6363
}
64-
using var sha256 = SHA256.Create();
6564

6665
var secret = configuration.GitHubOptions.Value.WebhookToken;
67-
var bytes = Encoding.UTF8.GetBytes(secret + payload);
68-
var check = $"sha256={Encoding.UTF8.GetString(sha256.ComputeHash(bytes))}";
66+
var secretBytes = Encoding.UTF8.GetBytes(secret);
67+
var payloadbytes = Encoding.UTF8.GetBytes(payload);
68+
69+
using var digest = new HMACSHA256(secretBytes);
70+
var check = $"sha256={Encoding.UTF8.GetString(digest.ComputeHash(payloadbytes))}";
6971

7072
return signature == check;
7173
}

0 commit comments

Comments
 (0)