-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version output is inconsistent with other tools #12280
Comments
So to clarify, ideally for the rust-up component build we should provide the following format |
We might as well use that format every time. |
Right, I'm suggesting to match the format, but also to make sure the channel is some kind of release, not one that "pokes". |
Yes not poking is definitely somethign we'd want. For our dev builds we don't want to show something like |
This is minor, but I noticed the version output in
rust-analyzer-preview
builds fromrustup
is inconsistent with other tools:RUST_ANALYZER_CHANNEL
in the build script. It's not a big deal, except it also triggerspoke_rust_analyzer_developer
, which we probably don't want in official builds. Maybe rustbuild should set this to "preview" for now, and eventually follow rustc's own channel names.This may be something to track in #4224.
The text was updated successfully, but these errors were encountered: