Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to manual: does not handle the unsafe modifier on traits #19254

Open
gvozdvmozgu opened this issue Mar 1, 2025 · 0 comments · May be fixed by #19320
Open

Convert to manual: does not handle the unsafe modifier on traits #19254

gvozdvmozgu opened this issue Mar 1, 2025 · 0 comments · May be fixed by #19320
Assignees
Labels
A-assists C-bug Category: bug

Comments

@gvozdvmozgu
Copy link
Contributor

The code should have added unsafe before impl since the trait is unsafe.

#[derive(salsa::Update)]
struct Test {}

becomes

impl salsa::Update for Test {
    unsafe fn maybe_update(old_pointer: *mut Self, new_value: Self) -> bool {
        todo!()
    }
}
@gvozdvmozgu gvozdvmozgu added the C-bug Category: bug label Mar 1, 2025
@alibektas alibektas self-assigned this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-assists C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants