Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

I can't use this project simply by dragging into my workspace #31

Open
drkibitz opened this issue Oct 15, 2018 · 4 comments
Open

I can't use this project simply by dragging into my workspace #31

drkibitz opened this issue Oct 15, 2018 · 4 comments

Comments

@drkibitz
Copy link

The copy-frameworks target fails when I am building through Xcode.

@drkibitz
Copy link
Author

I'm also realizing another issue is that it expects to have been installed by carthage before building.

Carthage allows the use of submodules, which means I expect to be able to bootstrap my project, commit things, and let other people just use git without carthage to build it.

This project breaks this pattern, but I would like to know what your thoughts on about fixing it, and if you would like to take a stab, or would like the community to take a stab? Just let me know if you can, thanks!

@ryokosuge
Copy link
Owner

@drkibitz Thank you for a nice suggestion!
I thought about using it for my project, so I thought it would be fine if I could build with Carthage and CocoaPods.

I think I will challenge to be able to add even with drap and drop!
If something troubles happens, please let me talk.

@drkibitz
Copy link
Author

drkibitz commented Nov 8, 2018

@ryokosuge The only thing that needs to happen is removing the copy-frameworks run phase in this project. If you read the Carthage documentation for developing frameworks, it actually mentions to not include this phase for your framework. It's meant for App development.

@drkibitz
Copy link
Author

@ryokosuge can we remove the copy-frameworks step?
This is causing a lot of headaches and I ended up forking it to remove it myself?
I can submit a PR, but I would like some feedback before I do that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants