Merge pull request #107 from ryoppippi/feature/fix-eslint

Refactor: new eslint config & fix lint

Author: ryoppippi

bun.lockb

@@ -1,4 +1,5 @@
 import antfu from '@antfu/eslint-config';
+import { join } from 'pathe';
 
 export default antfu({
 	formatters: true,
@@ -16,4 +17,8 @@ export default antfu({
 		quotes: 'single',
 		semi: true,
 	},
+
+	typescript: {
+		tsconfigPath: join(import.meta.dirname, 'tsconfig.json'),
+	},
 });

packages/unplugin-typia/eslint.config.js

@@ -92,13 +92,13 @@
 		"unplugin": "^1.5.1"
 	},
 	"devDependencies": {
-		"@antfu/eslint-config": "^2.18.0",
+		"@antfu/eslint-config": "^2.21.1",
 		"@std/assert": "npm:@jsr/std__assert",
 		"@types/bun": "^1.1.3",
 		"@types/node": "^20.10.3",
 		"consola": "^3.2.3",
 		"defu": "^6.1.4",
-		"eslint": "^8.55.0",
+		"eslint": "^9.5.0",
 		"eslint-plugin-format": "^0.1.1",
 		"pkg-types": "^1.1.1",
 		"rollup": "^4.6.1",

packages/unplugin-typia/package.json

@@ -29,7 +29,7 @@ export async function getCache(
 	if (!option.enable) {
 		return null;
 	}
-	prepareCacheDir(option);
+	await prepareCacheDir(option);
 
 	const key = getKey(id, source);
 	const path = getCachePath(key, option);
@@ -74,7 +74,7 @@ export async function setCache(
 	if (!option.enable) {
 		return;
 	}
-	prepareCacheDir(option);
+	await prepareCacheDir(option);
 
 	const key = getKey(id, source);
 	const path = getCachePath(key, option);
@@ -87,7 +87,7 @@ export async function setCache(
 
 	const cache = data + hashComment;
 	if (isBun()) {
-		Bun.write(path, cache, { createPath: true });
+		await Bun.write(path, cache, { createPath: true });
 	}
 	else {
 		await writeFile(path, cache, { encoding: 'utf8' });
@@ -125,13 +125,14 @@ async function prepareCacheDir(option: ResolvedCacheOptions) {
 	if (cacheDir != null) {
 		return;
 	}
-	await mkdir(option.base, { recursive: true });
+	const _cacheDir = option.base;
+	await mkdir(_cacheDir, { recursive: true });
 
-	if (!isWritable) {
+	if (!await isWritable(_cacheDir)) {
 		throw new Error('Cache directory is not writable.');
 	}
 
-	cacheDir = option.base;
+	cacheDir = _cacheDir;
 }
 
 async function isWritable(filename: string): Promise<boolean> {

packages/unplugin-typia/src/core/cache.ts

@@ -12,7 +12,7 @@ import { transformTypia } from './typia.js';
 import { getCache, setCache } from './cache.js';
 import { log } from './utils.js';
 
-const name = 'unplugin-typia' as const;
+const name = `unplugin-typia`;
 
 /**
  * Create a filter function from the given include and exclude patterns.
@@ -36,7 +36,7 @@ const unpluginFactory: UnpluginFactory<
 
 	const { cache: cacheOptions, log: logOption } = options;
 
-	if (logOption) {
+	if (logOption !== false) {
 		log(
 			'box',
 			cacheOptions.enable ? `Cache enabled` : `Cache disabled`,

packages/unplugin-typia/src/core/index.ts

@@ -28,14 +28,16 @@ import type { Options } from './core/options.js';
  * );
  * ```
  */
-function next(nextConfig: Record<string, any> = {}, options: Options): Record<string, any> {
+function next(nextConfig: Record<string, unknown> = {}, options: Options): Record<string, unknown> {
 	return {
 		...nextConfig,
-		webpack(config: Record<string, any>, webpackOptions: Record<string, any>) {
-			config.plugins.unshift(webpack(options));
+		webpack(config: Record<string, unknown>, webpackOptions: Record<string, unknown>) {
+			if (Array.isArray(config?.plugins)) {
+				config.plugins.unshift(webpack(options));
+			}
 
-			if (typeof nextConfig.webpack === 'function') {
-				return nextConfig.webpack(config, webpackOptions);
+			if (typeof nextConfig?.webpack === 'function') {
+				return nextConfig.webpack(config, webpackOptions) as Record<string, unknown>;
 			}
 
 			return config;

packages/unplugin-typia/src/next.ts

@@ -12,6 +12,8 @@ function removeComments(data: string | null) {
 	if (data == null) {
 		return data;
 	}
+
+	// eslint-disable-next-line regexp/no-unused-capturing-group
 	return data.replace(/\/\*[\s\S]*?\*\/|([^\\:]|^)\/\/.*$/gm, '');
 }