Fix XML/RPC.php under PHP 8

xml_parser could not be converted to int. The ${var} to {$var} change avoids a depracation warning.

Author: onli

bundled-libs/XML/RPC.php

@@ -1433,7 +1433,7 @@ function parseResponse($data = '')
 
         $encoding = $this->getEncoding($data);
         $parser_resource = xml_parser_create($encoding);
-        $parser = (int) $parser_resource;
+        $parser = 1;
 
         $XML_RPC_xh = array();
         $XML_RPC_xh[$parser] = array();
@@ -1590,7 +1590,7 @@ function addScalar($val, $type = 'string')
         }
         $typeof = $GLOBALS['XML_RPC_Types'][$type];
         if ($typeof != 1) {
-            $this->raiseError("Not a scalar type (${typeof})",
+            $this->raiseError("Not a scalar type ({$typeof})",
                               XML_RPC_ERROR_INVALID_TYPE);
             return 0;
         }
@@ -1723,16 +1723,16 @@ function serializedata($typ, $val)
         case 1:
             switch ($typ) {
             case $GLOBALS['XML_RPC_Base64']:
-                $rs .= "<${typ}>" . base64_encode($val) . "</${typ}>";
+                $rs .= "<{$typ}>" . base64_encode($val) . "</{$typ}>";
                 break;
             case $GLOBALS['XML_RPC_Boolean']:
-                $rs .= "<${typ}>" . ($val ? '1' : '0') . "</${typ}>";
+                $rs .= "<{$typ}>" . ($val ? '1' : '0') . "</{$typ}>";
                 break;
             case $GLOBALS['XML_RPC_String']:
-                $rs .= "<${typ}>" . serendipity_specialchars($val). "</${typ}>";
+                $rs .= "<{$typ}>" . serendipity_specialchars($val). "</{$typ}>";
                 break;
             default:
-                $rs .= "<${typ}>${val}</${typ}>";
+                $rs .= "<{$typ}>{$val}</{$typ}>";
             }
         }
         return $rs;

docs/NEWS

@@ -1,6 +1,8 @@
 Version 2.6-alpha1 ()
 ------------------------------------------------------------------------
 
+   * PHP 8 compatibility fixes for bundled XML/RPC.php
+
    * Upgrade bundled jQuery to jQuery 3
 
    * Fix option to set a different theme as fallback option by setting