Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out tests in waveform and waveform_backend #123

Open
sabjorn opened this issue Aug 10, 2022 · 1 comment
Open

Fill out tests in waveform and waveform_backend #123

sabjorn opened this issue Aug 10, 2022 · 1 comment

Comments

@sabjorn
Copy link
Owner

sabjorn commented Aug 10, 2022

We have chained functions (via fetch and offlineAudioContext) which are not really tested in the code. The "was this function called" code exists BUT the functions that are called as a result are not tested.

This really isn't a high priority because the waveform obviously works. However, it's just not great to rely on this sort of visual check.

@sabjorn
Copy link
Owner Author

sabjorn commented Dec 6, 2024

examples of testing that might be helpful here:

  • this one shows how to return a promise with a stub
  • this shows how to get a function that is passed as an argument to a stub in order to test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant