Skip to content

Commit e764be0

Browse files
authored
Mark middlewares as depreacted (#397)
* Mark `middleware`s as depreacted * Add changeset
1 parent acd1974 commit e764be0

9 files changed

+27
-2
lines changed

.changeset/witty-carrots-occur.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@saleor/app-sdk": patch
3+
---
4+
5+
Marked `/middleware`s as deprecated in favor of `/handlers`

src/middleware/middleware-debug.ts

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ type DebugFactory = (handlerName: string) => (msg: string, ...args: unknown[]) =
99

1010
/**
1111
* Experimental. Needs to be tested and evaluated on security
12+
*
13+
* @depreacted Use `/handlers` instead of middlewares
1214
*/
1315
export const withReqResDebugging =
1416
(debugFactory: DebugFactory = createMiddlewareDebug): Middleware =>

src/middleware/with-auth-token-required.ts

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import { createMiddlewareDebug } from "./middleware-debug";
55

66
const debug = createMiddlewareDebug("withAuthTokenRequired");
77

8+
/**
9+
* @deprecated Use `/handlers` instead of middlewares
10+
* */
811
export const withAuthTokenRequired: Middleware = (handler) => async (request) => {
912
debug("Middleware called");
1013

src/middleware/with-base-url.ts

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import { createMiddlewareDebug } from "./middleware-debug";
55

66
const debug = createMiddlewareDebug("withBaseURL");
77

8+
/**
9+
* @deprecated Use `/handlers` instead of middlewares
10+
* */
811
export const withBaseURL: Middleware = (handler) => async (request) => {
912
const { host, "x-forwarded-proto": protocol = "http" } = request.headers;
1013

src/middleware/with-jwt-verified.ts

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ export interface DashboardTokenPayload extends jose.JWTPayload {
1515

1616
const ERROR_MESSAGE = "JWT verification failed:";
1717

18+
/**
19+
* @deprecated Use `/handlers` instead of middlewares
20+
* */
1821
export const withJWTVerified =
1922
(getAppId: (request: Request) => Promise<string | undefined>): Middleware =>
2023
(handler) =>

src/middleware/with-registered-saleor-domain-header.ts

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ import { getSaleorAppFromRequest } from "./with-saleor-app";
77

88
const debug = createMiddlewareDebug("withRegisteredSaleorDomainHeader");
99

10+
/**
11+
* @deprecated Use `/handlers` instead of middlewares
12+
* */
1013
export const withRegisteredSaleorDomainHeader: Middleware = (handler) => async (request) => {
1114
const { saleorApiUrl } = getSaleorHeaders(request.headers);
1215

src/middleware/with-saleor-app.ts

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import { createMiddlewareDebug } from "./middleware-debug";
55

66
const debug = createMiddlewareDebug("withSaleorApp");
77

8+
/**
9+
* @deprecated Use `/handlers` instead of middlewares
10+
* */
811
export const withSaleorApp =
912
(saleorApp: SaleorApp): Middleware =>
1013
(handler) =>

src/middleware/with-saleor-event-match.ts

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ import { createMiddlewareDebug } from "./middleware-debug";
66

77
const debug = createMiddlewareDebug("withSaleorEventMatch");
88

9+
/**
10+
* @deprecated Use `/handlers` instead of middlewares
11+
* */
912
export const withSaleorEventMatch =
1013
<E extends string>(expectedEvent: `${Lowercase<E>}`): Middleware =>
1114
(handler) =>

src/middleware/with-webhook-signature-verified.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ const debug = createMiddlewareDebug("withWebhookSignatureVerified");
1212
const ERROR_MESSAGE = "Webhook signature verification failed:";
1313

1414
/**
15-
* TODO: Add test
16-
*/
15+
* @deprecated Use `/handlers` instead of middlewares
16+
* */
1717
export const withWebhookSignatureVerified =
1818
(secretKey: string | undefined = undefined): Middleware =>
1919
(handler) =>

0 commit comments

Comments
 (0)